From 1abbe9b02ce235a588aa56a4b80bca444eb1a1ec Mon Sep 17 00:00:00 2001 From: Idan Horowitz Date: Tue, 25 Jan 2022 15:50:18 +0200 Subject: [PATCH] Kernel: Ignore allocation failures when appending threads to coredump We shouldn't panic due to a failure in coredump generation --- Kernel/Process.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Kernel/Process.cpp b/Kernel/Process.cpp index 278e2f7b58..7191cd0611 100644 --- a/Kernel/Process.cpp +++ b/Kernel/Process.cpp @@ -659,7 +659,9 @@ void Process::die() VERIFY(m_threads_for_coredump.is_empty()); for_each_thread([&](auto& thread) { - m_threads_for_coredump.append(thread); + auto result = m_threads_for_coredump.try_append(thread); + if (result.is_error()) + dbgln("Failed to add thread {} to coredump due to OOM", thread.tid()); }); all_instances().with([&](const auto& list) {