RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 07:57:47 +00:00
Code Issues Activity Actions

strace: Use Core::System::exec()

Browse source
This commit is contained in:
Sam Atkins 2022-04-02 15:33:08 +01:00 • committed by Andreas Kling
parent 3e5b1b1dbc
commit 1ac6c4df72
1 changed files with 2 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Utilities/strace.cpp
View file

@ -809,7 +809,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
{ {
TRY(Core::System::pledge("stdio wpath cpath proc exec ptrace sigaction")); TRY(Core::System::pledge("stdio wpath cpath proc exec ptrace sigaction"));
Vector<char const*> child_argv; Vector<StringView> child_argv;
char const* output_filename = nullptr; char const* output_filename = nullptr;
char const* exclude_syscalls_option = nullptr; char const* exclude_syscalls_option = nullptr;
@ -849,17 +849,11 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
if (child_argv.is_empty()) if (child_argv.is_empty())
return Error::from_string_literal("Expected either a pid or some arguments"sv); return Error::from_string_literal("Expected either a pid or some arguments"sv);
child_argv.append(nullptr);
auto pid = TRY(Core::System::fork()); auto pid = TRY(Core::System::fork());
if (!pid) { if (!pid) {
TRY(Core::System::ptrace(PT_TRACE_ME, 0, 0, 0)); TRY(Core::System::ptrace(PT_TRACE_ME, 0, 0, 0));
TRY(Core::System::exec(child_argv.first(), child_argv, Core::System::SearchInPath::Yes));
int rc = execvp(child_argv.first(), const_cast<char**>(child_argv.data()));
if (rc < 0) {
perror("execvp");
exit(1);
}
VERIFY_NOT_REACHED(); VERIFY_NOT_REACHED();
} }