RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:37:35 +00:00
Code Issues Activity Actions

JsonParser: "" is an empty string, not a null value

Browse source
This commit is contained in:
Andreas Kling 2019-08-14 14:51:17 +02:00
parent f6fe56d011
commit 1ac963b5c8
2 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
AK/JsonParser.cpp
View file

@ -101,7 +101,7 @@ String JsonParser::consume_quoted_string()
consume_specific('"'); consume_specific('"');
if (buffer.is_empty()) if (buffer.is_empty())
return {}; return String::empty();
auto& last_string_starting_with_character = m_last_string_starting_with_character[(int)buffer.first()]; auto& last_string_starting_with_character = m_last_string_starting_with_character[(int)buffer.first()];
if (last_string_starting_with_character.length() == buffer.size()) { if (last_string_starting_with_character.length() == buffer.size()) {

8
AK/Tests/TestJSON.cpp
View file

@ -66,4 +66,12 @@ BENCHMARK_CASE(load_4chan_catalog)
} }
} }
TEST_CASE(json_empty_string)
{
auto json = JsonValue::from_string("\"\"");
EXPECT_EQ(json.type(), JsonValue::Type::String);
EXPECT_EQ(json.as_string().is_null(), false);
EXPECT_EQ(json.as_string().is_empty(), true);
}
TEST_MAIN(JSON) TEST_MAIN(JSON)