RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-23 10:37:41 +00:00
Code Issues Activity Actions

Kernel: Add implied auto-specifiers in Locking

Browse source 
As per clang-tidy.
This commit is contained in:
Hendiadyoin1 2021-12-15 14:56:39 +01:00 • committed by Brian Gianforcaro
parent a7209ca0f9
commit 1ad4a190b5
2 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/Locking/LockRank.cpp
View file

@ -15,7 +15,7 @@ namespace Kernel {
void track_lock_acquire(LockRank rank) void track_lock_acquire(LockRank rank)
{ {
if constexpr (LOCK_RANK_ENFORCEMENT) { if constexpr (LOCK_RANK_ENFORCEMENT) {
auto thread = Thread::current(); auto* thread = Thread::current();
if (thread && !thread->is_crashing()) if (thread && !thread->is_crashing())
thread->track_lock_acquire(rank); thread->track_lock_acquire(rank);
} }
@ -24,7 +24,7 @@ void track_lock_acquire(LockRank rank)
void track_lock_release(LockRank rank) void track_lock_release(LockRank rank)
{ {
if constexpr (LOCK_RANK_ENFORCEMENT) { if constexpr (LOCK_RANK_ENFORCEMENT) {
auto thread = Thread::current(); auto* thread = Thread::current();
if (thread && !thread->is_crashing()) if (thread && !thread->is_crashing())
thread->track_lock_release(rank); thread->track_lock_release(rank);
} }

8
Kernel/Locking/Mutex.cpp
View file

@ -21,7 +21,7 @@ void Mutex::lock(Mode mode, [[maybe_unused]] LockLocation const& location)
if constexpr (LOCK_IN_CRITICAL_DEBUG) if constexpr (LOCK_IN_CRITICAL_DEBUG)
VERIFY_INTERRUPTS_ENABLED(); VERIFY_INTERRUPTS_ENABLED();
VERIFY(mode != Mode::Unlocked); VERIFY(mode != Mode::Unlocked);
auto current_thread = Thread::current(); auto* current_thread = Thread::current();
SpinlockLocker lock(m_lock); SpinlockLocker lock(m_lock);
bool did_block = false; bool did_block = false;
@ -148,7 +148,7 @@ void Mutex::unlock()
if constexpr (LOCK_IN_CRITICAL_DEBUG) if constexpr (LOCK_IN_CRITICAL_DEBUG)
VERIFY_INTERRUPTS_ENABLED(); VERIFY_INTERRUPTS_ENABLED();
VERIFY(!Processor::current_in_irq()); VERIFY(!Processor::current_in_irq());
auto current_thread = Thread::current(); auto* current_thread = Thread::current();
SpinlockLocker lock(m_lock); SpinlockLocker lock(m_lock);
Mode current_mode = m_mode; Mode current_mode = m_mode;
if constexpr (LOCK_TRACE_DEBUG) { if constexpr (LOCK_TRACE_DEBUG) {
@ -260,7 +260,7 @@ auto Mutex::force_unlock_if_locked(u32& lock_count_to_restore) -> Mode
// NOTE: This may be called from an interrupt handler (not an IRQ handler) // NOTE: This may be called from an interrupt handler (not an IRQ handler)
// and also from within critical sections! // and also from within critical sections!
VERIFY(!Processor::current_in_irq()); VERIFY(!Processor::current_in_irq());
auto current_thread = Thread::current(); auto* current_thread = Thread::current();
SpinlockLocker lock(m_lock); SpinlockLocker lock(m_lock);
auto current_mode = m_mode; auto current_mode = m_mode;
switch (current_mode) { switch (current_mode) {
@ -323,7 +323,7 @@ void Mutex::restore_lock(Mode mode, u32 lock_count, [[maybe_unused]] LockLocatio
VERIFY(mode != Mode::Unlocked); VERIFY(mode != Mode::Unlocked);
VERIFY(lock_count > 0); VERIFY(lock_count > 0);
VERIFY(!Processor::current_in_irq()); VERIFY(!Processor::current_in_irq());
auto current_thread = Thread::current(); auto* current_thread = Thread::current();
bool did_block = false; bool did_block = false;
SpinlockLocker lock(m_lock); SpinlockLocker lock(m_lock);
switch (mode) { switch (mode) {