RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 20:28:11 +00:00
Code Issues Activity Actions

LibCore+Everywhere: Move SeekMode out of IODevice

Browse source
This commit is contained in:
Ali Mohammad Pur 2021-05-12 14:01:34 +04:30 • committed by Linus Groh
parent a91a49337c
commit 1ae8775a1b
5 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibCore/FileStream.h
View file

@ -63,7 +63,7 @@ public:
return true;
}
bool discard_or_error(size_t count) override { return m_file->seek(count, IODevice::SeekMode::FromCurrentPosition); }
bool discard_or_error(size_t count) override { return m_file->seek(count, SeekMode::FromCurrentPosition); }
bool unreliable_eof() const override { return m_file->eof(); }

12
Userland/Libraries/LibCore/IODevice.h
View file

@ -44,6 +44,12 @@ enum class OpenMode : unsigned {
MustBeNew = 16,
};
enum class SeekMode {
SetPosition,
FromCurrentPosition,
FromEndPosition,
};
AK_ENUM_BITWISE_OPERATORS(OpenMode)
class IODevice : public Object {
@ -76,12 +82,6 @@ public:
bool can_read() const;
enum class SeekMode {
SetPosition,
FromCurrentPosition,
FromEndPosition,
};
bool seek(i64, SeekMode = SeekMode::SetPosition, off_t* = nullptr);
virtual bool open(OpenMode) = 0;

2
Userland/Libraries/LibCore/ProcessStatisticsReader.cpp
View file

@ -20,7 +20,7 @@ HashMap<uid_t, String> ProcessStatisticsReader::s_usernames;
Optional<HashMap<pid_t, Core::ProcessStatistics>> ProcessStatisticsReader::get_all(RefPtr<Core::File>& proc_all_file)
{
if (proc_all_file) {
if (!proc_all_file->seek(0, Core::File::SeekMode::SetPosition)) {
if (!proc_all_file->seek(0, Core::SeekMode::SetPosition)) {
fprintf(stderr, "ProcessStatisticsReader: Failed to refresh /proc/all: %s\n", proc_all_file->error_string());
return {};
}