RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 19:38:12 +00:00
Code Issues Activity Actions

Ladybird/Qt: Replace the QString-from-AK helpers with a single method

Browse source 
There's no need for 2 overloads for String and DeprecatedString, we can
just use a StringView. This also avoids some cases of needlessly
allocating a DeprecatedString from a StringView when calling this
method.
This commit is contained in:
Timothy Flynn 2023-12-04 09:55:47 -05:00 • committed by Andrew Kaster
parent 4d5d282e6a
commit 1aedb0ae5a
8 changed files with 21 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Ladybird/Qt/Settings.cpp
View file

@ -17,7 +17,7 @@ Settings::Settings()
m_qsettings = make<QSettings>("SerenityOS", "Ladybird", this);
auto default_search_engine = WebView::default_search_engine();
auto default_search_engine_name = qstring_from_ak_deprecated_string(default_search_engine.name);
auto default_search_engine_name = qstring_from_ak_string(default_search_engine.name);
auto search_engine_name = m_qsettings->value("search_engine_name", default_search_engine_name).toString();
auto search_engine = WebView::find_search_engine_by_name(MUST(ak_string_from_qstring(search_engine_name)));
@ -62,7 +62,7 @@ void Settings::set_is_maximized(bool is_maximized)
void Settings::set_search_engine(WebView::SearchEngine search_engine)
{
m_qsettings->setValue("search_engine_name", qstring_from_ak_deprecated_string(search_engine.name));
m_qsettings->setValue("search_engine_name", qstring_from_ak_string(search_engine.name));
m_search_engine = move(search_engine);
}