1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 23:37:36 +00:00

Kernel: Make File's can_read/can_write take a const FileDescription&

Asking a File if we could possibly read or write it will never mutate
the asking FileDescription&, so it should be const.
This commit is contained in:
Andreas Kling 2019-11-04 14:03:14 +01:00
parent e8fee92357
commit 1b2ef8582c
47 changed files with 97 additions and 91 deletions

View file

@ -150,12 +150,12 @@ int BXVGADevice::ioctl(FileDescription&, unsigned request, unsigned arg)
};
}
bool BXVGADevice::can_read(FileDescription&) const
bool BXVGADevice::can_read(const FileDescription&) const
{
ASSERT_NOT_REACHED();
}
bool BXVGADevice::can_write(FileDescription&) const
bool BXVGADevice::can_write(const FileDescription&) const
{
ASSERT_NOT_REACHED();
}

View file

@ -17,8 +17,8 @@ public:
private:
virtual const char* class_name() const override { return "BXVGA"; }
virtual bool can_read(FileDescription&) const override;
virtual bool can_write(FileDescription&) const override;
virtual bool can_read(const FileDescription&) const override;
virtual bool can_write(const FileDescription&) const override;
virtual ssize_t read(FileDescription&, u8*, ssize_t) override;
virtual ssize_t write(FileDescription&, const u8*, ssize_t) override;

View file

@ -11,7 +11,7 @@ private:
// ^CharacterDevice
virtual ssize_t read(FileDescription&, u8*, ssize_t) override { return 0; }
virtual ssize_t write(FileDescription&, const u8*, ssize_t) override;
virtual bool can_write(FileDescription&) const override { return true; }
virtual bool can_read(FileDescription&) const override { return true; }
virtual bool can_write(const FileDescription&) const override { return true; }
virtual bool can_read(const FileDescription&) const override { return true; }
virtual const char* class_name() const override { return "DebugLogDevice"; }
};

View file

@ -15,9 +15,9 @@ public:
// ^BlockDevice
virtual ssize_t read(FileDescription&, u8*, ssize_t) override { return 0; }
virtual bool can_read(FileDescription&) const override { return true; }
virtual bool can_read(const FileDescription&) const override { return true; }
virtual ssize_t write(FileDescription&, const u8*, ssize_t) override { return 0; }
virtual bool can_write(FileDescription&) const override { return true; }
virtual bool can_write(const FileDescription&) const override { return true; }
private:
virtual const char* class_name() const override;

View file

@ -143,9 +143,9 @@ public:
// ^BlockDevice
virtual ssize_t read(FileDescription&, u8*, ssize_t) override { return 0; }
virtual bool can_read(FileDescription&) const override { return true; }
virtual bool can_read(const FileDescription&) const override { return true; }
virtual ssize_t write(FileDescription&, const u8*, ssize_t) override { return 0; }
virtual bool can_write(FileDescription&) const override { return true; }
virtual bool can_write(const FileDescription&) const override { return true; }
protected:
explicit FloppyDiskDevice(DriveType);

View file

@ -12,7 +12,7 @@ FullDevice::~FullDevice()
{
}
bool FullDevice::can_read(FileDescription&) const
bool FullDevice::can_read(const FileDescription&) const
{
return true;
}

View file

@ -12,7 +12,7 @@ private:
// ^CharacterDevice
virtual ssize_t read(FileDescription&, u8*, ssize_t) override;
virtual ssize_t write(FileDescription&, const u8*, ssize_t) override;
virtual bool can_read(FileDescription&) const override;
virtual bool can_write(FileDescription&) const override { return true; }
virtual bool can_read(const FileDescription&) const override;
virtual bool can_write(const FileDescription&) const override { return true; }
virtual const char* class_name() const override { return "FullDevice"; }
};

View file

@ -368,7 +368,7 @@ KeyboardDevice::~KeyboardDevice()
{
}
bool KeyboardDevice::can_read(FileDescription&) const
bool KeyboardDevice::can_read(const FileDescription&) const
{
return !m_queue.is_empty();
}

View file

@ -24,9 +24,9 @@ public:
// ^CharacterDevice
virtual ssize_t read(FileDescription&, u8* buffer, ssize_t) override;
virtual bool can_read(FileDescription&) const override;
virtual bool can_read(const FileDescription&) const override;
virtual ssize_t write(FileDescription&, const u8* buffer, ssize_t) override;
virtual bool can_write(FileDescription&) const override { return true; }
virtual bool can_write(const FileDescription&) const override { return true; }
private:
// ^IRQHandler

View file

@ -82,12 +82,12 @@ int MBVGADevice::ioctl(FileDescription&, unsigned request, unsigned arg)
};
}
bool MBVGADevice::can_read(FileDescription&) const
bool MBVGADevice::can_read(const FileDescription&) const
{
ASSERT_NOT_REACHED();
}
bool MBVGADevice::can_write(FileDescription&) const
bool MBVGADevice::can_write(const FileDescription&) const
{
ASSERT_NOT_REACHED();
}

View file

@ -17,8 +17,8 @@ public:
private:
virtual const char* class_name() const override { return "MBVGA"; }
virtual bool can_read(FileDescription&) const override;
virtual bool can_write(FileDescription&) const override;
virtual bool can_read(const FileDescription&) const override;
virtual bool can_write(const FileDescription&) const override;
virtual ssize_t read(FileDescription&, u8*, ssize_t) override;
virtual ssize_t write(FileDescription&, const u8*, ssize_t) override;

View file

@ -20,7 +20,7 @@ NullDevice::~NullDevice()
{
}
bool NullDevice::can_read(FileDescription&) const
bool NullDevice::can_read(const FileDescription&) const
{
return true;
}

View file

@ -14,7 +14,7 @@ private:
// ^CharacterDevice
virtual ssize_t read(FileDescription&, u8*, ssize_t) override;
virtual ssize_t write(FileDescription&, const u8*, ssize_t) override;
virtual bool can_write(FileDescription&) const override { return true; }
virtual bool can_read(FileDescription&) const override;
virtual bool can_write(const FileDescription&) const override { return true; }
virtual bool can_read(const FileDescription&) const override;
virtual const char* class_name() const override { return "NullDevice"; }
};

View file

@ -36,9 +36,9 @@ public:
// ^BlockDevice
virtual ssize_t read(FileDescription&, u8*, ssize_t) override { return 0; }
virtual bool can_read(FileDescription&) const override { return true; }
virtual bool can_read(const FileDescription&) const override { return true; }
virtual ssize_t write(FileDescription&, const u8*, ssize_t) override { return 0; }
virtual bool can_write(FileDescription&) const override { return true; }
virtual bool can_write(const FileDescription&) const override { return true; }
protected:
explicit PATADiskDevice(PATAChannel&, DriveType, int, int);

View file

@ -255,7 +255,7 @@ u8 PS2MouseDevice::mouse_read()
return IO::in8(I8042_BUFFER);
}
bool PS2MouseDevice::can_read(FileDescription&) const
bool PS2MouseDevice::can_read(const FileDescription&) const
{
return !m_queue.is_empty();
}

View file

@ -14,10 +14,10 @@ public:
static PS2MouseDevice& the();
// ^CharacterDevice
virtual bool can_read(FileDescription&) const override;
virtual bool can_read(const FileDescription&) const override;
virtual ssize_t read(FileDescription&, u8*, ssize_t) override;
virtual ssize_t write(FileDescription&, const u8*, ssize_t) override;
virtual bool can_write(FileDescription&) const override { return true; }
virtual bool can_write(const FileDescription&) const override { return true; }
private:
// ^IRQHandler

View file

@ -26,7 +26,7 @@ static void mysrand(unsigned seed)
}
#endif
bool RandomDevice::can_read(FileDescription&) const
bool RandomDevice::can_read(const FileDescription&) const
{
return true;
}

View file

@ -14,7 +14,7 @@ private:
// ^CharacterDevice
virtual ssize_t read(FileDescription&, u8*, ssize_t) override;
virtual ssize_t write(FileDescription&, const u8*, ssize_t) override;
virtual bool can_read(FileDescription&) const override;
virtual bool can_write(FileDescription&) const override { return true; }
virtual bool can_read(const FileDescription&) const override;
virtual bool can_write(const FileDescription&) const override { return true; }
virtual const char* class_name() const override { return "RandomDevice"; }
};

View file

@ -84,7 +84,7 @@ void SB16::initialize()
enable_irq();
}
bool SB16::can_read(FileDescription&) const
bool SB16::can_read(const FileDescription&) const
{
return false;
}

View file

@ -17,10 +17,10 @@ public:
static SB16& the();
// ^CharacterDevice
virtual bool can_read(FileDescription&) const override;
virtual bool can_read(const FileDescription&) const override;
virtual ssize_t read(FileDescription&, u8*, ssize_t) override;
virtual ssize_t write(FileDescription&, const u8*, ssize_t) override;
virtual bool can_write(FileDescription&) const override { return true; }
virtual bool can_write(const FileDescription&) const override { return true; }
private:
// ^IRQHandler

View file

@ -12,7 +12,7 @@ SerialDevice::~SerialDevice()
{
}
bool SerialDevice::can_read(FileDescription&) const
bool SerialDevice::can_read(const FileDescription&) const
{
return (get_line_status() & DataReady) != 0;
}
@ -30,7 +30,7 @@ ssize_t SerialDevice::read(FileDescription&, u8* buffer, ssize_t size)
return 1;
}
bool SerialDevice::can_write(FileDescription&) const
bool SerialDevice::can_write(const FileDescription&) const
{
return (get_line_status() & EmptyTransmitterHoldingRegister) != 0;
}

View file

@ -12,9 +12,9 @@ public:
virtual ~SerialDevice() override;
// ^CharacterDevice
virtual bool can_read(FileDescription&) const override;
virtual bool can_read(const FileDescription&) const override;
virtual ssize_t read(FileDescription&, u8*, ssize_t) override;
virtual bool can_write(FileDescription&) const override;
virtual bool can_write(const FileDescription&) const override;
virtual ssize_t write(FileDescription&, const u8*, ssize_t) override;
enum InterruptEnable {

View file

@ -11,7 +11,7 @@ ZeroDevice::~ZeroDevice()
{
}
bool ZeroDevice::can_read(FileDescription&) const
bool ZeroDevice::can_read(const FileDescription&) const
{
return true;
}

View file

@ -12,7 +12,7 @@ private:
// ^CharacterDevice
virtual ssize_t read(FileDescription&, u8*, ssize_t) override;
virtual ssize_t write(FileDescription&, const u8*, ssize_t) override;
virtual bool can_read(FileDescription&) const override;
virtual bool can_write(FileDescription&) const override { return true; }
virtual bool can_read(const FileDescription&) const override;
virtual bool can_write(const FileDescription&) const override { return true; }
virtual const char* class_name() const override { return "ZeroDevice"; }
};