From 1b3cac2f42ea8dd9026b541bc705f5909fef71ed Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Tue, 21 Jan 2020 11:42:28 +0100 Subject: [PATCH] Kernel: Don't forget about unveiled paths with zero permissions We need to keep these around, otherwise the calling process can remove and re-add a path to increase its permissions. --- Kernel/Process.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Kernel/Process.cpp b/Kernel/Process.cpp index 1bc28a11d1..6be807edaa 100644 --- a/Kernel/Process.cpp +++ b/Kernel/Process.cpp @@ -4657,10 +4657,6 @@ int Process::sys$unveil(const Syscall::SC_unveil_params* user_params) if (unveiled_path.path == path.value()) { if (new_permissions & ~unveiled_path.permissions) return -EPERM; - if (!new_permissions) { - m_unveiled_paths.remove(i); - return 0; - } unveiled_path.permissions = new_permissions; return 0; }