RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 16:38:10 +00:00
Code Issues Activity Actions

LibWeb: Preserve case for key events

Browse source 
Case-preserving behavior matches observed behavior of other browsers and
the specification.
This commit is contained in:
Andi Gallo 2023-05-23 02:33:57 +00:00 • committed by Andreas Kling
parent 02d94a303c
commit 1bbfe4630d
1 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Userland/Libraries/LibWeb/UIEvents/KeyboardEvent.cpp
View file

@ -66,12 +66,26 @@ static unsigned long determine_key_code(KeyCode platform_key, u32 code_point)
return platform_key;
}
static ErrorOr<String> get_event_key(KeyCode platform_key, u32 code_point)
{
auto event_key = String::from_deprecated_string(key_code_to_string(platform_key));
if (event_key.is_error()) {
return event_key;
}
// Original case should be preserved for the key value of the event.
// https://www.w3.org/TR/uievents-key/#key-attr-values
if (is_ascii_lower_alpha(code_point)) {
event_key = event_key.release_value().to_lowercase();
}
return event_key;
}
WebIDL::ExceptionOr<JS::NonnullGCPtr<KeyboardEvent>> KeyboardEvent::create_from_platform_event(JS::Realm& realm, FlyString const& event_name, KeyCode platform_key, unsigned modifiers, u32 code_point)
{
auto& vm = realm.vm();
// FIXME: Figure out what these should actually contain.
auto event_key = TRY_OR_THROW_OOM(vm, String::from_deprecated_string(key_code_to_string(platform_key)));
auto event_key = TRY_OR_THROW_OOM(vm, get_event_key(platform_key, code_point));
auto event_code = TRY_OR_THROW_OOM(vm, "FIXME"_string);
auto key_code = determine_key_code(platform_key, code_point);