RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 22:27:35 +00:00
Code Issues Activity Actions

LibWeb: Remove "cached corner bitmap" and its use in the corner clipper

Browse source 
With the recording painter the actual painting operations are delayed,
so now if multiple corner clippers are constructed, and they use a
shared bitmap they can interfere with each other. The use of this shared
bitmap was somewhat questionable anyway, so this is not much of a loss.

This fixes the border-radius.html test page.
This commit is contained in:
MacDue 2023-10-21 19:17:49 +01:00 • committed by Alexander Kalenik
parent 1a58fee0fd
commit 1c012f0a4a
5 changed files with 8 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/Painting/BorderRadiusCornerClipper.h
View file

@ -18,12 +18,7 @@ enum class CornerClip {
class BorderRadiusCornerClipper : public RefCounted<BorderRadiusCornerClipper> {
public:
enum class UseCachedBitmap {
Yes,
No
};
static ErrorOr<NonnullRefPtr<BorderRadiusCornerClipper>> create(CornerRadii const&, DevicePixelRect const& border_rect, BorderRadiiData const& border_radii, CornerClip corner_clip = CornerClip::Outside, UseCachedBitmap use_cached_bitmap = UseCachedBitmap::Yes);
static ErrorOr<NonnullRefPtr<BorderRadiusCornerClipper>> create(CornerRadii const&, DevicePixelRect const& border_rect, BorderRadiiData const& border_radii, CornerClip corner_clip = CornerClip::Outside);
void sample_under_corners(Gfx::Painter& page_painter);
void blit_corner_clipping(Gfx::Painter& page_painter);
@ -38,7 +33,6 @@ public:
};
CornerLocations page_locations;
CornerLocations bitmap_locations;
DevicePixelSize corner_bitmap_size;
} m_data;
DevicePixelRect border_rect() const { return m_border_rect; }
@ -59,7 +53,7 @@ private:
};
struct ScopedCornerRadiusClip {
ScopedCornerRadiusClip(PaintContext& context, DevicePixelRect const& border_rect, BorderRadiiData const& border_radii, CornerClip corner_clip = CornerClip::Outside, BorderRadiusCornerClipper::UseCachedBitmap use_cached_bitmap = BorderRadiusCornerClipper::UseCachedBitmap::Yes);
ScopedCornerRadiusClip(PaintContext& context, DevicePixelRect const& border_rect, BorderRadiiData const& border_radii, CornerClip corner_clip = CornerClip::Outside);
~ScopedCornerRadiusClip();