1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 15:07:45 +00:00

LibDraw: Introduce (formerly known as SharedGraphics.)

Instead of LibGUI and WindowServer building their own copies of the drawing
and graphics code, let's it in a separate LibDraw library.

This avoids building the code twice, and will encourage better separation
of concerns. :^)
This commit is contained in:
Andreas Kling 2019-07-18 10:15:00 +02:00
parent 2167f60235
commit 1c0669f010
120 changed files with 201 additions and 190 deletions

View file

@ -2,7 +2,7 @@
#include <LibCore/CTimer.h>
#include <LibGUI/GWidget.h>
#include <SharedGraphics/TextAlignment.h>
#include <LibDraw/TextAlignment.h>
class GPainter;

View file

@ -9,7 +9,7 @@
#include <AK/WeakPtr.h>
#include <AK/Weakable.h>
#include <LibGUI/GShortcut.h>
#include <SharedGraphics/GraphicsBitmap.h>
#include <LibDraw/GraphicsBitmap.h>
class GActionGroup;
class GButton;

View file

@ -4,7 +4,7 @@
#include <LibGUI/GActionGroup.h>
#include <LibGUI/GButton.h>
#include <LibGUI/GPainter.h>
#include <SharedGraphics/StylePainter.h>
#include <LibDraw/StylePainter.h>
GButton::GButton(GWidget* parent)
: GAbstractButton(parent)

View file

@ -3,9 +3,9 @@
#include <AK/AKString.h>
#include <AK/Function.h>
#include <LibGUI/GAbstractButton.h>
#include <SharedGraphics/GraphicsBitmap.h>
#include <SharedGraphics/StylePainter.h>
#include <SharedGraphics/TextAlignment.h>
#include <LibDraw/GraphicsBitmap.h>
#include <LibDraw/StylePainter.h>
#include <LibDraw/TextAlignment.h>
class GAction;

View file

@ -1,8 +1,8 @@
#include <Kernel/KeyCode.h>
#include <LibGUI/GCheckBox.h>
#include <LibGUI/GPainter.h>
#include <SharedGraphics/CharacterBitmap.h>
#include <SharedGraphics/StylePainter.h>
#include <LibDraw/CharacterBitmap.h>
#include <LibDraw/StylePainter.h>
static const char* s_checked_bitmap_data = {
" "

View file

@ -3,7 +3,7 @@
#include <AK/AKString.h>
#include <AK/Badge.h>
#include <AK/Function.h>
#include <SharedGraphics/Rect.h>
#include <LibDraw/Rect.h>
class GWindowServerConnection;

View file

@ -4,7 +4,7 @@
#include <LibCore/CDirIterator.h>
#include <LibCore/CLock.h>
#include <LibGUI/GPainter.h>
#include <SharedGraphics/GraphicsBitmap.h>
#include <LibDraw/GraphicsBitmap.h>
#include <dirent.h>
#include <grp.h>
#include <pwd.h>

View file

@ -3,8 +3,8 @@
#include <Kernel/KeyCode.h>
#include <LibCore/CEvent.h>
#include <LibGUI/GWindowType.h>
#include <SharedGraphics/Point.h>
#include <SharedGraphics/Rect.h>
#include <LibDraw/Point.h>
#include <LibDraw/Rect.h>
class CObject;

View file

@ -11,7 +11,7 @@
#include <LibGUI/GSortingProxyModel.h>
#include <LibGUI/GTextBox.h>
#include <LibGUI/GToolBar.h>
#include <SharedGraphics/PNGLoader.h>
#include <LibDraw/PNGLoader.h>
Optional<String> GFilePicker::get_open_filepath()
{

View file

@ -1,6 +1,6 @@
#include <LibCore/CDirIterator.h>
#include <LibGUI/GFontDatabase.h>
#include <SharedGraphics/Font.h>
#include <LibDraw/Font.h>
#include <dirent.h>
#include <stdio.h>
#include <stdlib.h>

View file

@ -1,6 +1,6 @@
#include <LibGUI/GFrame.h>
#include <LibGUI/GPainter.h>
#include <SharedGraphics/StylePainter.h>
#include <LibDraw/StylePainter.h>
GFrame::GFrame(GWidget* parent)
: GWidget(parent)

View file

@ -1,7 +1,7 @@
#pragma once
#include <LibGUI/GWidget.h>
#include <SharedGraphics/StylePainter.h>
#include <LibDraw/StylePainter.h>
class GFrame : public GWidget {
public:

View file

@ -1,6 +1,6 @@
#include <LibGUI/GGroupBox.h>
#include <LibGUI/GPainter.h>
#include <SharedGraphics/StylePainter.h>
#include <LibDraw/StylePainter.h>
GGroupBox::GGroupBox(GWidget* parent)
: GGroupBox({}, parent)

View file

@ -1,7 +1,7 @@
#pragma once
#include <AK/HashMap.h>
#include <SharedGraphics/GraphicsBitmap.h>
#include <LibDraw/GraphicsBitmap.h>
class GIconImpl : public RefCounted<GIconImpl> {
public:

View file

@ -1,6 +1,6 @@
#include "GLabel.h"
#include <LibGUI/GPainter.h>
#include <SharedGraphics/GraphicsBitmap.h>
#include <LibDraw/GraphicsBitmap.h>
GLabel::GLabel(GWidget* parent)
: GFrame(parent)

View file

@ -1,7 +1,7 @@
#pragma once
#include <LibGUI/GFrame.h>
#include <SharedGraphics/TextAlignment.h>
#include <LibDraw/TextAlignment.h>
class GraphicsBitmap;

View file

@ -7,7 +7,7 @@
#include <AK/RefCounted.h>
#include <LibGUI/GModelIndex.h>
#include <LibGUI/GVariant.h>
#include <SharedGraphics/TextAlignment.h>
#include <LibDraw/TextAlignment.h>
class Font;
class GAbstractView;

View file

@ -1,6 +1,6 @@
#pragma once
#include <SharedGraphics/Painter.h>
#include <LibDraw/Painter.h>
class GWidget;
class GraphicsBitmap;

View file

@ -1,6 +1,6 @@
#include <LibGUI/GPainter.h>
#include <LibGUI/GRadioButton.h>
#include <SharedGraphics/GraphicsBitmap.h>
#include <LibDraw/GraphicsBitmap.h>
static RefPtr<GraphicsBitmap> s_unfilled_circle_bitmap;
static RefPtr<GraphicsBitmap> s_filled_circle_bitmap;

View file

@ -1,7 +1,7 @@
#include <LibGUI/GPainter.h>
#include <LibGUI/GResizeCorner.h>
#include <LibGUI/GWindow.h>
#include <SharedGraphics/GraphicsBitmap.h>
#include <LibDraw/GraphicsBitmap.h>
#include <WindowServer/WSAPITypes.h>
GResizeCorner::GResizeCorner(GWidget* parent)

View file

@ -1,8 +1,8 @@
#include <LibGUI/GPainter.h>
#include <LibGUI/GScrollBar.h>
#include <SharedGraphics/CharacterBitmap.h>
#include <SharedGraphics/GraphicsBitmap.h>
#include <SharedGraphics/StylePainter.h>
#include <LibDraw/CharacterBitmap.h>
#include <LibDraw/GraphicsBitmap.h>
#include <LibDraw/StylePainter.h>
static const char* s_up_arrow_bitmap_data = {
" "

View file

@ -1,6 +1,6 @@
#include <LibGUI/GPainter.h>
#include <LibGUI/GSlider.h>
#include <SharedGraphics/StylePainter.h>
#include <LibDraw/StylePainter.h>
GSlider::GSlider(GWidget* parent)
: GWidget(parent)

View file

@ -3,7 +3,7 @@
#include <LibGUI/GPainter.h>
#include <LibGUI/GResizeCorner.h>
#include <LibGUI/GStatusBar.h>
#include <SharedGraphics/StylePainter.h>
#include <LibDraw/StylePainter.h>
GStatusBar::GStatusBar(GWidget* parent)
: GWidget(parent)

View file

@ -1,7 +1,7 @@
#include <LibGUI/GBoxLayout.h>
#include <LibGUI/GPainter.h>
#include <LibGUI/GTabWidget.h>
#include <SharedGraphics/StylePainter.h>
#include <LibDraw/StylePainter.h>
GTabWidget::GTabWidget(GWidget* parent)
: GWidget(parent)

View file

@ -3,7 +3,7 @@
#include <AK/Function.h>
#include <AK/HashMap.h>
#include <LibGUI/GScrollableWidget.h>
#include <SharedGraphics/TextAlignment.h>
#include <LibDraw/TextAlignment.h>
class GAction;
class GMenu;

View file

@ -2,7 +2,7 @@
#include <AK/AKString.h>
#include <LibGUI/GIcon.h>
#include <SharedGraphics/GraphicsBitmap.h>
#include <LibDraw/GraphicsBitmap.h>
namespace AK {
class JsonValue;

View file

@ -8,7 +8,7 @@
#include <LibGUI/GLayout.h>
#include <LibGUI/GMenu.h>
#include <LibGUI/GPainter.h>
#include <SharedGraphics/GraphicsBitmap.h>
#include <LibDraw/GraphicsBitmap.h>
#include <unistd.h>
GWidget::GWidget(GWidget* parent)

View file

@ -7,9 +7,9 @@
#include <LibCore/CObject.h>
#include <LibGUI/GEvent.h>
#include <LibGUI/GShortcut.h>
#include <SharedGraphics/Color.h>
#include <SharedGraphics/Font.h>
#include <SharedGraphics/Rect.h>
#include <LibDraw/Color.h>
#include <LibDraw/Font.h>
#include <LibDraw/Rect.h>
class GraphicsBitmap;
class GAction;

View file

@ -8,7 +8,7 @@
#include <LibC/stdlib.h>
#include <LibC/unistd.h>
#include <LibGUI/GPainter.h>
#include <SharedGraphics/GraphicsBitmap.h>
#include <LibDraw/GraphicsBitmap.h>
//#define UPDATE_COALESCING_DEBUG

View file

@ -5,8 +5,8 @@
#include <AK/WeakPtr.h>
#include <LibCore/CObject.h>
#include <LibGUI/GWindowType.h>
#include <SharedGraphics/GraphicsBitmap.h>
#include <SharedGraphics/Rect.h>
#include <LibDraw/GraphicsBitmap.h>
#include <LibDraw/Rect.h>
class GWidget;
class GWMEvent;

View file

@ -1,16 +1,6 @@
include ../../Makefile.common
SHAREDGRAPHICS_OBJS = \
../../SharedGraphics/Painter.o \
../../SharedGraphics/StylePainter.o \
../../SharedGraphics/Font.o \
../../SharedGraphics/Rect.o \
../../SharedGraphics/GraphicsBitmap.o \
../../SharedGraphics/CharacterBitmap.o \
../../SharedGraphics/Color.o \
../../SharedGraphics/PNGLoader.o
LIBGUI_OBJS = \
OBJS = \
GPainter.o \
GButton.o \
GCheckBox.o \
@ -64,8 +54,6 @@ LIBGUI_OBJS = \
GComboBox.o \
GWindow.o
OBJS = $(SHAREDGRAPHICS_OBJS) $(LIBGUI_OBJS)
LIBRARY = libgui.a
DEFINES += -DUSERLAND