mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 16:27:35 +00:00
Kernel: Use KResultOr<size_t> throughout the TTY subsystem
Previously the VirtualConsole::on_tty_write() method would return an incorrect value when an error had occurred. This prompted me to update the TTY subsystem to use KResultOr<size_t> everywhere.
This commit is contained in:
parent
a49a15cabf
commit
1c3346e3ce
9 changed files with 29 additions and 29 deletions
|
@ -40,11 +40,11 @@ void SlavePTY::echo(u8 ch)
|
|||
{
|
||||
if (should_echo_input()) {
|
||||
auto buffer = UserOrKernelBuffer::for_kernel_buffer(&ch);
|
||||
m_master->on_slave_write(buffer, 1);
|
||||
[[maybe_unused]] auto result = m_master->on_slave_write(buffer, 1);
|
||||
}
|
||||
}
|
||||
|
||||
void SlavePTY::on_master_write(const UserOrKernelBuffer& buffer, ssize_t size)
|
||||
void SlavePTY::on_master_write(const UserOrKernelBuffer& buffer, size_t size)
|
||||
{
|
||||
auto result = buffer.read_buffered<128>(size, [&](u8 const* data, size_t data_size) {
|
||||
for (size_t i = 0; i < data_size; ++i)
|
||||
|
@ -55,7 +55,7 @@ void SlavePTY::on_master_write(const UserOrKernelBuffer& buffer, ssize_t size)
|
|||
evaluate_block_conditions();
|
||||
}
|
||||
|
||||
ssize_t SlavePTY::on_tty_write(const UserOrKernelBuffer& data, ssize_t size)
|
||||
KResultOr<size_t> SlavePTY::on_tty_write(const UserOrKernelBuffer& data, size_t size)
|
||||
{
|
||||
m_time_of_last_write = kgettimeofday().to_truncated_seconds();
|
||||
return m_master->on_slave_write(data, size);
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue