RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:07:36 +00:00
Code Issues Activity Actions

LibJS+Clients: Add JS::VM object, separate Heap from Interpreter

Browse source 
Taking a big step towards a world of multiple global object, this patch
adds a new JS::VM object that houses the JS::Heap.

This means that the Heap moves out of Interpreter, and the same Heap
can now be used by multiple Interpreters, and can also outlive them.

The VM keeps a stack of Interpreter pointers. We push/pop on this
stack when entering/exiting execution with a given Interpreter.
This allows us to make this change without disturbing too much of
the existing code.

There is still a 1-to-1 relationship between Interpreter and the
global object. This will change in the future.

Ultimately, the goal here is to make Interpreter a transient object
that only needs to exist while you execute some code. Getting there
will take a lot more work though. :^)

Note that in LibWeb, the global JS::VM is called main_thread_vm(),
to distinguish it from future worker VM's.
This commit is contained in:
Andreas Kling 2020-09-20 19:24:44 +02:00
parent c6ae0c41d9
commit 1c43442be4
13 changed files with 218 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibJS/Heap/Heap.h
View file

@ -43,7 +43,7 @@ class Heap {
AK_MAKE_NONMOVABLE(Heap);
public:
explicit Heap(Interpreter&);
explicit Heap(VM&);
~Heap();
template<typename T, typename... Args>
@ -71,7 +71,8 @@ public:
void collect_garbage(CollectionType = CollectionType::CollectGarbage, bool print_report = false);
Interpreter& interpreter() { return m_interpreter; }
Interpreter& interpreter();
VM& vm() { return m_vm; }
bool should_collect_on_every_allocation() const { return m_should_collect_on_every_allocation; }
void set_should_collect_on_every_allocation(bool b) { m_should_collect_on_every_allocation = b; }
@ -100,7 +101,7 @@ private:
bool m_should_collect_on_every_allocation { false };
Interpreter& m_interpreter;
VM& m_vm;
Vector<NonnullOwnPtr<HeapBlock>> m_blocks;
HashTable<HandleImpl*> m_handles;