RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 01:57:44 +00:00
Code Issues Activity Actions

LibWeb: Treat "revert" as a CSS-wide keyword

Browse source 
This isn't included in the base definition of a CSS-wide keyword, but
the CASCADE-4 spec which adds it says:

> The revert CSS-wide keyword rolls back the cascade to the cascaded
  value of the earlier origin.

So it is one. While I'm at it, rename `is_builtin()` to match the spec
terminology. It's not used currently, but will be in the next commit.
This commit is contained in:
Sam Atkins 2023-09-20 16:58:45 +01:00 • committed by Sam Atkins
parent aea112da71
commit 1c4a05f8a4
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateCSSValueID.cpp
View file

@ -71,10 +71,12 @@ Optional<ValueID> value_id_from_string(StringView);
StringView string_from_value_id(ValueID); StringView string_from_value_id(ValueID);
// https://www.w3.org/TR/css-values-4/#common-keywords // https://www.w3.org/TR/css-values-4/#common-keywords
// https://drafts.csswg.org/css-cascade-4/#valdef-all-revert
inline bool is_css_wide_keyword(StringView name) inline bool is_css_wide_keyword(StringView name)
{ {
return name.equals_ignoring_ascii_case("inherit"sv) return name.equals_ignoring_ascii_case("inherit"sv)
|| name.equals_ignoring_ascii_case("initial"sv) || name.equals_ignoring_ascii_case("initial"sv)
|| name.equals_ignoring_ascii_case("revert"sv)
|| name.equals_ignoring_ascii_case("unset"sv); || name.equals_ignoring_ascii_case("unset"sv);
} }

4
Userland/Libraries/LibWeb/CSS/StyleValue.h
View file

@ -157,7 +157,9 @@ public:
AbstractImageStyleValue const& as_abstract_image() const; AbstractImageStyleValue const& as_abstract_image() const;
AbstractImageStyleValue& as_abstract_image() { return const_cast<AbstractImageStyleValue&>(const_cast<StyleValue const&>(*this).as_abstract_image()); } AbstractImageStyleValue& as_abstract_image() { return const_cast<AbstractImageStyleValue&>(const_cast<StyleValue const&>(*this).as_abstract_image()); }
bool is_builtin() const { return is_inherit() || is_initial() || is_unset(); } // https://www.w3.org/TR/css-values-4/#common-keywords
// https://drafts.csswg.org/css-cascade-4/#valdef-all-revert
bool is_css_wide_keyword() const { return is_inherit() || is_initial() || is_revert() || is_unset(); }
bool has_auto() const; bool has_auto() const;
virtual bool has_color() const { return false; } virtual bool has_color() const { return false; }