RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:28:12 +00:00
Code Issues Activity Actions

LibWeb/Fetch: Refactor forbidden request-headers

Browse source 
This is a change in the Fetch spec.

See:
- 92e6c91
- 494431a
This commit is contained in:
Linus Groh 2022-12-07 18:16:32 +00:00
parent 011f6a6cb4
commit 1c9bb2d8b4
5 changed files with 125 additions and 79 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/Libraries/LibWeb/XHR/XMLHttpRequest.cpp
View file

@ -310,15 +310,16 @@ WebIDL::ExceptionOr<void> XMLHttpRequest::set_request_header(DeprecatedString co
if (!Fetch::Infrastructure::is_header_value(value))
return WebIDL::SyntaxError::create(realm, "Header value contains invalid characters.");
// 5. If name is a forbidden header name, then return.
if (Fetch::Infrastructure::is_forbidden_header_name(name))
return {};
// 6. Combine (name, value) in this’s author request headers.
auto header = Fetch::Infrastructure::Header {
.name = move(name),
.value = move(value),
};
// 5. If (name, value) is a forbidden request-header, then return.
if (TRY_OR_RETURN_OOM(realm, Fetch::Infrastructure::is_forbidden_request_header(header)))
return {};
// 6. Combine (name, value) in this’s author request headers.
TRY_OR_RETURN_OOM(realm, m_author_request_headers->combine(move(header)));
return {};