RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:27:43 +00:00
Code Issues Activity Actions

Kernel: Use size_t to keep track of the number of pages in a region

Browse source 
We were previously using a 32-bit unsigned integer for this, which
caused us to start truncating region sizes when multiplied with
`PAGE_SIZE` on hardware with a lot of memory.
This commit is contained in:
Tim Schumacher 2022-12-07 03:03:38 +01:00 • committed by Linus Groh
parent 4aa70a07ca
commit 1ca0898b1c
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/Memory/PhysicalRegion.cpp
View file

@ -63,7 +63,7 @@ void PhysicalRegion::initialize_zones()
make_zones(small_zone_size); make_zones(small_zone_size);
} }
OwnPtr<PhysicalRegion> PhysicalRegion::try_take_pages_from_beginning(unsigned page_count) OwnPtr<PhysicalRegion> PhysicalRegion::try_take_pages_from_beginning(size_t page_count)
{ {
VERIFY(page_count > 0); VERIFY(page_count > 0);
VERIFY(page_count < m_pages); VERIFY(page_count < m_pages);

6
Kernel/Memory/PhysicalRegion.h
View file

@ -28,10 +28,10 @@ public:
PhysicalAddress lower() const { return m_lower; } PhysicalAddress lower() const { return m_lower; }
PhysicalAddress upper() const { return m_upper; } PhysicalAddress upper() const { return m_upper; }
unsigned size() const { return m_pages; } size_t size() const { return m_pages; }
bool contains(PhysicalAddress paddr) const { return paddr >= m_lower && paddr < m_upper; } bool contains(PhysicalAddress paddr) const { return paddr >= m_lower && paddr < m_upper; }
OwnPtr<PhysicalRegion> try_take_pages_from_beginning(unsigned); OwnPtr<PhysicalRegion> try_take_pages_from_beginning(size_t);
RefPtr<PhysicalPage> take_free_page(); RefPtr<PhysicalPage> take_free_page();
NonnullRefPtrVector<PhysicalPage> take_contiguous_free_pages(size_t count); NonnullRefPtrVector<PhysicalPage> take_contiguous_free_pages(size_t count);
@ -52,7 +52,7 @@ private:
PhysicalAddress m_lower; PhysicalAddress m_lower;
PhysicalAddress m_upper; PhysicalAddress m_upper;
unsigned m_pages { 0 }; size_t m_pages { 0 };
}; };
} }