RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 15:27:35 +00:00
Code Issues Activity Actions

LibWeb: Prevent crash when inspecting SVG documents

Browse source 
(Or any document with aria-hidden=true on the root)
This commit is contained in:
MacDue 2023-06-26 22:41:25 +01:00 • committed by Sam Atkins
parent 9430bbcc62
commit 1cc199d365
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/DOM/Node.cpp
View file

@ -1638,7 +1638,7 @@ void Node::build_accessibility_tree(AccessibilityTreeNode& parent)
if (is_document()) {
auto* document = static_cast<DOM::Document*>(this);
auto* document_element = document->document_element();
if (document_element) {
if (document_element && document_element->include_in_accessibility_tree()) {
parent.set_value(document_element);
if (document_element->has_child_nodes())
document_element->for_each_child([&parent](DOM::Node& child) {

4
Userland/Libraries/LibWebView/AccessibilityTreeModel.cpp
View file

@ -93,8 +93,8 @@ GUI::Variant AccessibilityTreeModel::data(GUI::ModelIndex const& index, GUI::Mod
if (type != "element")
return node_role;
auto name = node.get_deprecated_string("name"sv).value();
auto description = node.get_deprecated_string("description"sv).value();
auto name = node.get_deprecated_string("name"sv).value_or("");
auto description = node.get_deprecated_string("description"sv).value_or("");
StringBuilder builder;
builder.append(node_role.to_lowercase());