RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 09:57:35 +00:00
Code Issues Activity Actions

LibGUI: Give some widgets a reasonable default fixed height

Browse source 
Instead of hard-coding 22 in random places, just make the following
widgets have a fixed height of 22 by default: Button, CheckBox,
ColorInput, ComboBox, RadioButton, SpinBox, TextBox.

In the future we can make this relative to the current font size,
but for now at least this centralizes the setting a bit better.
This commit is contained in:
Andreas Kling 2020-12-30 01:53:13 +01:00
parent 0f3b0b65ae
commit 1cca2405fc
17 changed files with 11 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Demos/DynamicObject/main.cpp
View file

@ -68,7 +68,6 @@ int main([[maybe_unused]] int argc, [[maybe_unused]] char** argv, [[maybe_unused
auto& button = main_widget.add<GUI::Button>();
button.set_text("Good-bye");
button.set_fixed_height(20);
button.on_click = [&](auto) {
app->quit();
};

1
Demos/HelloWorld/main.cpp
View file

@ -68,7 +68,6 @@ int main(int argc, char** argv)
auto& button = main_widget.add<GUI::Button>();
button.set_text("Good-bye");
button.set_fixed_height(20);
button.on_click = [&](auto) {
app->quit();
};

6
Demos/WidgetGallery/main.cpp
View file

@ -175,9 +175,11 @@ int main(int argc, char** argv)
auto& checkbox2 = checkbox_container.add<GUI::CheckBox>("CheckBox 2");
checkbox2.set_enabled(false);
[[maybe_unused]] auto& label1 = label_container.add<GUI::Label>("Label 1");
auto& label1 = label_container.add<GUI::Label>("Label 1");
label1.set_fixed_height(22);
auto& label2 = label_container.add<GUI::Label>("Label 2");
label2.set_enabled(false);
label2.set_fixed_height(22);
[[maybe_unused]] auto& spinbox1 = spin_container.add<GUI::SpinBox>();
auto& spinbox2 = spin_container.add<GUI::SpinBox>();
@ -424,7 +426,6 @@ int main(int argc, char** argv)
content_textbox.set_text("Demo text for message box.");
auto& msgbox_button = msgbox_text_container.add<GUI::Button>("Create");
msgbox_button.set_fixed_height(30);
msgbox_button.on_click = [&](auto) {
GUI::MessageBox::show(window, content_textbox.text(), title_textbox.text(), msg_box_type, msg_box_input_type);
};
@ -446,7 +447,6 @@ int main(int argc, char** argv)
input_button_container.layout()->set_margins({ 4, 0, 4, 0 });
auto& input_button = input_button_container.add<GUI::Button>("Input...");
input_button.set_fixed_height(30);
String value;
input_button.on_click = [&](auto) {
if (GUI::InputBox::show(value, window, "Enter input:", "Input Box") == GUI::InputBox::ExecOK && !value.is_empty())