RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 14:42:44 +00:00
Code Issues Activity Actions

Userland+Tests: Don't use MAP_FILE when mmap-ing

Browse source 
MAP_FILE is not in POSIX, and is simply in most LibCs as a "default"
mode. Our own LibC defines it as 0, meaning "no flags". It is also not
defined in some OS's, such as Haiku. Let's be more portable and not use
the unnecessary flag.
This commit is contained in:
Andrew Kaster 2023-09-01 09:53:12 +02:00 • committed by Jelle Raaijmakers
parent f642b54b5e
commit 1cd3826ad6
9 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Tests/Kernel/TestEmptySharedInodeVMObject.cpp
View file

@ -32,7 +32,7 @@ TEST_CASE(shared_zero_length_inode_vmobject_sync)
}
int fd = open("/tmp/shared_msync_test", O_RDWR | O_CREAT, 0644);
VERIFY(fd >= 0);
shared_ptr = (u8*)mmap(nullptr, 0x1000, PROT_READ | PROT_WRITE, MAP_FILE | MAP_SHARED, fd, 0);
shared_ptr = (u8*)mmap(nullptr, 0x1000, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
EXPECT(shared_ptr != MAP_FAILED);
shared_ptr[0] = 0x1;
VERIFY_NOT_REACHED();