Everywhere: Use LibFileSystem where trivial

Userland/Libraries/LibCodeComprehension/Cpp/CMakeLists.txt

@@ -17,4 +17,4 @@ set(SOURCES
 
 serenity_bin(CppComprehensionTests)
 
-target_link_libraries(CppComprehensionTests PRIVATE LibCodeComprehension LibCore LibCpp LibRegex LibMain)
+target_link_libraries(CppComprehensionTests PRIVATE LibCodeComprehension LibCore LibCpp LibFileSystem LibRegex LibMain)

Userland/Libraries/LibCodeComprehension/Cpp/CppComprehensionEngine.cpp

@@ -9,12 +9,12 @@
 #include <AK/HashTable.h>
 #include <AK/OwnPtr.h>
 #include <AK/ScopeGuard.h>
-#include <LibCore/DeprecatedFile.h>
 #include <LibCore/DirIterator.h>
 #include <LibCpp/AST.h>
 #include <LibCpp/Lexer.h>
 #include <LibCpp/Parser.h>
 #include <LibCpp/Preprocessor.h>
+#include <LibFileSystem/FileSystem.h>
 #include <LibRegex/Regex.h>
 #include <Userland/DevTools/HackStudio/LanguageServers/ConnectionFromClient.h>
 
@@ -736,7 +736,7 @@ Optional<Vector<CodeComprehension::AutocompleteResultEntry>> CppComprehensionEng
         if (!path.starts_with(partial_basename))
             continue;
 
-        if (Core::DeprecatedFile::is_directory(LexicalPath::join(full_dir, path).string())) {
+        if (FileSystem::is_directory(LexicalPath::join(full_dir, path).string())) {
             // FIXME: Don't dismiss the autocomplete when filling these suggestions.
             auto completion = DeprecatedString::formatted("{}{}{}/", prefix, include_dir, path);
             options.empend(completion, include_dir.length() + partial_basename.length() + 1, CodeComprehension::Language::Cpp, path, CodeComprehension::AutocompleteResultEntry::HideAutocompleteAfterApplying::No);

Userland/Libraries/LibCoredump/Backtrace.cpp

@@ -9,12 +9,12 @@
 #include <AK/Platform.h>
 #include <AK/StringBuilder.h>
 #include <AK/Types.h>
-#include <LibCore/DeprecatedFile.h>
 #include <LibCore/MappedFile.h>
 #include <LibCoredump/Backtrace.h>
 #include <LibCoredump/Reader.h>
 #include <LibELF/Core.h>
 #include <LibELF/Image.h>
+#include <LibFileSystem/FileSystem.h>
 
 namespace Coredump {
 
@@ -26,7 +26,7 @@ ELFObjectInfo const* Backtrace::object_info_for_region(Reader const& coredump, M
     if (maybe_ptr.has_value())
         return *maybe_ptr;
 
-    if (!Core::DeprecatedFile::exists(path))
+    if (!FileSystem::exists(path))
         return nullptr;
 
     auto file_or_error = Core::MappedFile::map(path);

Userland/Libraries/LibCoredump/CMakeLists.txt

@@ -5,4 +5,4 @@ set(SOURCES
 )
 
 serenity_lib(LibCoredump coredump)
-target_link_libraries(LibCoredump PRIVATE LibCompress LibCore LibDebug)
+target_link_libraries(LibCoredump PRIVATE LibCompress LibCore LibDebug LibFileSystem)

Userland/Libraries/LibCoredump/Reader.cpp

@@ -6,13 +6,14 @@
  */
 
 #include <AK/ByteReader.h>
+#include <AK/Function.h>
 #include <AK/HashTable.h>
 #include <AK/JsonObject.h>
 #include <AK/JsonValue.h>
 #include <AK/LexicalPath.h>
 #include <LibCompress/Gzip.h>
-#include <LibCore/DeprecatedFile.h>
 #include <LibCoredump/Reader.h>
+#include <LibFileSystem/FileSystem.h>
 #include <signal.h>
 #include <string.h>
 #include <unistd.h>
@@ -297,7 +298,7 @@ DeprecatedString Reader::resolve_object_path(StringView name) const
     //       (e.g. UserspaceEmulator, LibSymbolication, Profiler, and DynamicLinker itself)
     //       We should consider creating unified implementation in the future.
 
-    if (name.starts_with('/') || !Core::DeprecatedFile::looks_like_shared_library(name)) {
+    if (name.starts_with('/') || !FileSystem::looks_like_shared_library(name)) {
         return name;
     }
 

Userland/Libraries/LibDebug/CMakeLists.txt

@@ -14,4 +14,4 @@ set(SOURCES
 )
 
 serenity_lib(LibDebug debug)
-target_link_libraries(LibDebug PRIVATE LibCore LibRegex)
+target_link_libraries(LibDebug PRIVATE LibCore LibFileSystem LibRegex)

Userland/Libraries/LibDebug/DebugSession.cpp

@@ -11,6 +11,7 @@
 #include <AK/Optional.h>
 #include <AK/Platform.h>
 #include <LibCore/DeprecatedFile.h>
+#include <LibFileSystem/FileSystem.h>
 #include <LibRegex/Regex.h>
 #include <stdlib.h>
 #include <sys/mman.h>
@@ -487,7 +488,7 @@ void DebugSession::update_loaded_libs()
             return IterationDecision::Continue;
 
         DeprecatedString lib_name = object_path.value();
-        if (Core::DeprecatedFile::looks_like_shared_library(lib_name))
+        if (FileSystem::looks_like_shared_library(lib_name))
             lib_name = LexicalPath::basename(object_path.value());
 
         FlatPtr base_address = entry.as_object().get_addr("address"sv).value_or(0);

Userland/Libraries/LibFileSystemAccessClient/CMakeLists.txt

@@ -8,5 +8,5 @@ set(GENERATED_SOURCES
 )
 
 serenity_lib(LibFileSystemAccessClient filesystemaccessclient)
-target_link_libraries(LibFileSystemAccessClient PRIVATE LibCore LibIPC)
+target_link_libraries(LibFileSystemAccessClient PRIVATE LibCore LibFileSystem LibIPC)
 add_dependencies(LibFileSystemAccessClient WindowServer)

Userland/Libraries/LibFileSystemAccessClient/Client.cpp

@@ -7,6 +7,7 @@
 
 #include <AK/LexicalPath.h>
 #include <LibCore/DeprecatedFile.h>
+#include <LibFileSystem/FileSystem.h>
 #include <LibFileSystemAccessClient/Client.h>
 #include <LibGUI/ConnectionToWindowServer.h>
 #include <LibGUI/MessageBox.h>
@@ -128,13 +129,13 @@ void Client::handle_prompt_end(i32 request_id, i32 error, Optional<IPC::File> co
         return;
     }
 
-    if (Core::DeprecatedFile::is_device(ipc_file->fd())) {
+    if (FileSystem::is_device(*chosen_file)) {
         GUI::MessageBox::show_error(request_data.parent_window, DeprecatedString::formatted("Opening \"{}\" failed: Cannot open device files", *chosen_file));
         request_data.promise->resolve(Error::from_string_literal("Cannot open device files")).release_value_but_fixme_should_propagate_errors();
         return;
     }
 
-    if (Core::DeprecatedFile::is_directory(ipc_file->fd())) {
+    if (FileSystem::is_directory(*chosen_file)) {
         GUI::MessageBox::show_error(request_data.parent_window, DeprecatedString::formatted("Opening \"{}\" failed: Cannot open directory", *chosen_file));
         request_data.promise->resolve(Error::from_errno(EISDIR)).release_value_but_fixme_should_propagate_errors();
         return;

Userland/Libraries/LibGUI/CMakeLists.txt

@@ -143,4 +143,4 @@ set(GENERATED_SOURCES
 )
 
 serenity_lib(LibGUI gui)
-target_link_libraries(LibGUI PRIVATE LibCore LibGfx LibIPC LibThreading LibRegex LibSyntax LibConfig LibUnicode)
+target_link_libraries(LibGUI PRIVATE LibCore LibFileSystem LibGfx LibIPC LibThreading LibRegex LibSyntax LibConfig LibUnicode)

Userland/Libraries/LibGUI/CommonLocationsProvider.cpp

@@ -8,9 +8,9 @@
 #include <AK/JsonArray.h>
 #include <AK/JsonObject.h>
 #include <AK/Vector.h>
-#include <LibCore/DeprecatedFile.h>
 #include <LibCore/File.h>
 #include <LibCore/StandardPaths.h>
+#include <LibFileSystem/FileSystem.h>
 #include <LibGUI/CommonLocationsProvider.h>
 #include <unistd.h>
 
@@ -25,7 +25,7 @@ static void initialize_if_needed()
         return;
 
     auto user_config = DeprecatedString::formatted("{}/CommonLocations.json", Core::StandardPaths::config_directory());
-    if (Core::DeprecatedFile::exists(user_config)) {
+    if (FileSystem::exists(user_config)) {
         auto maybe_error = CommonLocationsProvider::load_from_json(user_config);
         if (!maybe_error.is_error())
             return;

Userland/Libraries/LibGUI/FilePicker.cpp

@@ -7,8 +7,8 @@
 #include <AK/Function.h>
 #include <AK/LexicalPath.h>
 #include <LibConfig/Client.h>
-#include <LibCore/DeprecatedFile.h>
 #include <LibCore/StandardPaths.h>
+#include <LibFileSystem/FileSystem.h>
 #include <LibGUI/Action.h>
 #include <LibGUI/BoxLayout.h>
 #include <LibGUI/Button.h>
@@ -320,7 +320,7 @@ void FilePicker::on_file_return()
         path = LexicalPath::join(m_model->root_path(), path).string();
     }
 
-    bool file_exists = Core::DeprecatedFile::exists(path);
+    bool file_exists = FileSystem::exists(path);
 
     if (!file_exists && (m_mode == Mode::Open || m_mode == Mode::OpenFolder)) {
         MessageBox::show(this, DeprecatedString::formatted("No such file or directory: {}", m_filename_textbox->text()), "File not found"sv, MessageBox::Type::Error, MessageBox::InputType::OK);

Userland/Libraries/LibGUI/PathBreadcrumbbar.cpp

@@ -9,8 +9,8 @@
 
 #include "PathBreadcrumbbar.h"
 #include <AK/LexicalPath.h>
-#include <LibCore/DeprecatedFile.h>
 #include <LibCore/MimeData.h>
+#include <LibFileSystem/FileSystem.h>
 #include <LibGUI/BoxLayout.h>
 #include <LibGUI/Breadcrumbbar.h>
 #include <LibGUI/FileIconProvider.h>
@@ -49,7 +49,7 @@ PathBreadcrumbbar::PathBreadcrumbbar(NonnullRefPtr<GUI::TextBox> location_text_b
     };
 
     m_location_text_box->on_return_pressed = [&] {
-        if (Core::DeprecatedFile::is_directory(m_location_text_box->text())) {
+        if (FileSystem::is_directory(m_location_text_box->text())) {
             set_current_path(m_location_text_box->text());
             hide_location_text_box();
         }
@@ -104,7 +104,7 @@ void PathBreadcrumbbar::set_current_path(DeprecatedString const& new_path)
         // If the path change was because the directory we were in was deleted,
         // remove the breadcrumbs for it.
         if ((new_segment_index + 1 < m_breadcrumbbar->segment_count())
-            && !Core::DeprecatedFile::is_directory(m_breadcrumbbar->segment_data(new_segment_index + 1))) {
+            && !FileSystem::is_directory(m_breadcrumbbar->segment_data(new_segment_index + 1))) {
             m_breadcrumbbar->remove_end_segments(new_segment_index + 1);
         }
     } else {

Userland/Libraries/LibGfx/CMakeLists.txt

@@ -63,4 +63,4 @@ set(SOURCES
 )
 
 serenity_lib(LibGfx gfx)
-target_link_libraries(LibGfx PRIVATE LibCompress LibCore LibCrypto LibTextCodec LibIPC LibUnicode)
+target_link_libraries(LibGfx PRIVATE LibCompress LibCore LibCrypto LibFileSystem LibTextCodec LibIPC LibUnicode)

Userland/Libraries/LibGfx/Font/FontDatabase.cpp

@@ -7,8 +7,8 @@
 #include <AK/DeprecatedFlyString.h>
 #include <AK/Queue.h>
 #include <AK/QuickSort.h>
-#include <LibCore/DeprecatedFile.h>
 #include <LibCore/DirIterator.h>
+#include <LibFileSystem/FileSystem.h>
 #include <LibGfx/Font/Font.h>
 #include <LibGfx/Font/FontDatabase.h>
 #include <LibGfx/Font/OpenType/Font.h>
@@ -135,7 +135,7 @@ void FontDatabase::load_all_fonts_from_path(DeprecatedString const& root)
         while (dir_iterator.has_next()) {
             auto path = dir_iterator.next_full_path();
 
-            if (Core::DeprecatedFile::is_directory(path)) {
+            if (FileSystem::is_directory(path)) {
                 path_queue.enqueue(path);
                 continue;
             }

Userland/Libraries/LibIDL/CMakeLists.txt

@@ -4,4 +4,4 @@ set(SOURCES
 )
 
 serenity_lib(LibIDL idl)
-target_link_libraries(LibIDL PRIVATE LibCore)
+target_link_libraries(LibIDL PRIVATE LibCore LibFileSystem)

Userland/Libraries/LibIDL/IDLParser.cpp

@@ -13,6 +13,7 @@
 #include <AK/QuickSort.h>
 #include <LibCore/DeprecatedFile.h>
 #include <LibCore/File.h>
+#include <LibFileSystem/FileSystem.h>
 
 [[noreturn]] static void report_parsing_error(StringView message, StringView filename, StringView input, size_t offset)
 {
@@ -138,7 +139,7 @@ static HashTable<DeprecatedString> import_stack;
 Optional<Interface&> Parser::resolve_import(auto path)
 {
     auto include_path = LexicalPath::join(import_base_path, path).string();
-    if (!Core::DeprecatedFile::exists(include_path))
+    if (!FileSystem::exists(include_path))
         report_parsing_error(DeprecatedString::formatted("{}: No such file or directory", include_path), filename, input, lexer.tell());
 
     auto real_path = Core::DeprecatedFile::real_path_for(include_path);

Userland/Libraries/LibJS/CMakeLists.txt

@@ -265,4 +265,4 @@ set(SOURCES
 )
 
 serenity_lib(LibJS js)
-target_link_libraries(LibJS PRIVATE LibCore LibCrypto LibRegex LibSyntax LibLocale LibUnicode)
+target_link_libraries(LibJS PRIVATE LibCore LibCrypto LibFileSystem LibRegex LibSyntax LibLocale LibUnicode)

Userland/Libraries/LibJS/Runtime/VM.cpp

@@ -13,6 +13,7 @@
 #include <AK/String.h>
 #include <AK/StringBuilder.h>
 #include <LibCore/DeprecatedFile.h>
+#include <LibFileSystem/FileSystem.h>
 #include <LibJS/AST.h>
 #include <LibJS/Interpreter.h>
 #include <LibJS/Runtime/AbstractOperations.h>
@@ -854,18 +855,18 @@ static DeprecatedString resolve_module_filename(StringView filename, StringView
     auto extensions = Vector<StringView, 2> { "js"sv, "mjs"sv };
     if (module_type == "json"sv)
         extensions = { "json"sv };
-    if (!Core::DeprecatedFile::exists(filename)) {
+    if (!FileSystem::exists(filename)) {
         for (auto extension : extensions) {
             // import "./foo" -> import "./foo.ext"
             auto resolved_filepath = DeprecatedString::formatted("{}.{}", filename, extension);
-            if (Core::DeprecatedFile::exists(resolved_filepath))
+            if (FileSystem::exists(resolved_filepath))
                 return resolved_filepath;
         }
-    } else if (Core::DeprecatedFile::is_directory(filename)) {
+    } else if (FileSystem::is_directory(filename)) {
         for (auto extension : extensions) {
             // import "./foo" -> import "./foo/index.ext"
             auto resolved_filepath = LexicalPath::join(filename, DeprecatedString::formatted("index.{}", extension)).string();
-            if (Core::DeprecatedFile::exists(resolved_filepath))
+            if (FileSystem::exists(resolved_filepath))
                 return resolved_filepath;
         }
     }

Userland/Libraries/LibManual/CMakeLists.txt

@@ -7,4 +7,4 @@ set(SOURCES
 )
 
 serenity_lib(LibManual manual)
-target_link_libraries(LibManual PRIVATE LibCore)
+target_link_libraries(LibManual PRIVATE LibCore LibFileSystem)

Userland/Libraries/LibManual/Node.cpp

@@ -12,7 +12,7 @@
 #include <AK/Optional.h>
 #include <AK/StringView.h>
 #include <AK/URL.h>
-#include <LibCore/DeprecatedFile.h>
+#include <LibFileSystem/FileSystem.h>
 #include <LibManual/Path.h>
 
 namespace Manual {
@@ -48,7 +48,7 @@ ErrorOr<NonnullRefPtr<PageNode const>> Node::try_create_from_query(Vector<String
         Optional<NonnullRefPtr<PageNode>> maybe_page;
         for (auto const& section : sections) {
             auto const page = TRY(try_make_ref_counted<PageNode>(section, TRY(String::from_utf8(first_query_parameter))));
-            if (Core::DeprecatedFile::exists(TRY(page->path()))) {
+            if (FileSystem::exists(TRY(page->path()))) {
                 maybe_page = page;
                 break;
             }
@@ -61,7 +61,7 @@ ErrorOr<NonnullRefPtr<PageNode const>> Node::try_create_from_query(Vector<String
     auto second_query_parameter = *query_parameter_iterator;
     auto section = TRY(SectionNode::try_create_from_number(first_query_parameter));
     auto const page = TRY(try_make_ref_counted<PageNode>(section, TRY(String::from_utf8(second_query_parameter))));
-    if (Core::DeprecatedFile::exists(TRY(page->path())))
+    if (FileSystem::exists(TRY(page->path())))
         return page;
     return Error::from_string_literal("Page doesn't exist in section");
 }

Userland/Libraries/LibManual/SectionNode.cpp

@@ -10,8 +10,8 @@
 #include "SubsectionNode.h"
 #include <AK/LexicalPath.h>
 #include <AK/QuickSort.h>
-#include <LibCore/DeprecatedFile.h>
 #include <LibCore/DirIterator.h>
+#include <LibFileSystem/FileSystem.h>
 
 namespace Manual {
 
@@ -54,7 +54,7 @@ ErrorOr<void> SectionNode::reify_if_needed() const
     while (dir_iter.has_next()) {
         LexicalPath lexical_path(dir_iter.next_path());
         if (lexical_path.extension() != "md") {
-            if (Core::DeprecatedFile::is_directory(LexicalPath::absolute_path(own_path.to_deprecated_string(), lexical_path.string()))) {
+            if (FileSystem::is_directory(LexicalPath::absolute_path(own_path.to_deprecated_string(), lexical_path.string()))) {
                 dbgln("Found subsection {}", lexical_path);
                 children.append({ .node = TRY(try_make_ref_counted<SubsectionNode>(*this, lexical_path.title())),
                     .name_for_sorting = TRY(String::from_utf8(lexical_path.title())) });

Userland/Libraries/LibSQL/CMakeLists.txt

@@ -41,4 +41,4 @@ set(GENERATED_SOURCES
 )
 
 serenity_lib(LibSQL sql)
-target_link_libraries(LibSQL PRIVATE LibCore LibIPC LibSyntax LibRegex)
+target_link_libraries(LibSQL PRIVATE LibCore LibFileSystem LibIPC LibSyntax LibRegex)

Userland/Libraries/LibSQL/SQLClient.cpp

@@ -10,11 +10,11 @@
 #include <LibSQL/SQLClient.h>
 
 #if !defined(AK_OS_SERENITY)
-#    include <LibCore/DeprecatedFile.h>
 #    include <LibCore/Directory.h>
 #    include <LibCore/SocketAddress.h>
 #    include <LibCore/StandardPaths.h>
 #    include <LibCore/System.h>
+#    include <LibFileSystem/FileSystem.h>
 #endif
 
 namespace SQL {
@@ -24,7 +24,7 @@ namespace SQL {
 // This is heavily based on how SystemServer's Service creates its socket.
 static ErrorOr<int> create_database_socket(DeprecatedString const& socket_path)
 {
-    if (Core::DeprecatedFile::exists(socket_path))
+    if (FileSystem::exists(socket_path))
         TRY(Core::System::unlink(socket_path));
 
 #    ifdef SOCK_NONBLOCK
@@ -102,7 +102,7 @@ static ErrorOr<void> launch_server(DeprecatedString const& socket_path, Deprecat
 
 static ErrorOr<bool> should_launch_server(DeprecatedString const& pid_path)
 {
-    if (!Core::DeprecatedFile::exists(pid_path))
+    if (!FileSystem::exists(pid_path))
         return true;
 
     Optional<pid_t> pid;

Userland/Libraries/LibSymbolication/CMakeLists.txt

@@ -3,4 +3,4 @@ set(SOURCES
 )
 
 serenity_lib(LibSymbolication symbolication)
-target_link_libraries(LibSymbolication PRIVATE LibCore LibDebug)
+target_link_libraries(LibSymbolication PRIVATE LibCore LibDebug LibFileSystem)

Userland/Libraries/LibSymbolication/Symbolication.cpp

@@ -13,6 +13,7 @@
 #include <LibCore/DeprecatedFile.h>
 #include <LibCore/MappedFile.h>
 #include <LibDebug/DebugInfo.h>
+#include <LibFileSystem/FileSystem.h>
 #include <LibSymbolication/Symbolication.h>
 
 namespace Symbolication {
@@ -65,7 +66,7 @@ Optional<Symbol> symbolicate(DeprecatedString const& path, FlatPtr address, Incl
         bool found = false;
         for (auto& search_path : search_paths) {
             full_path = LexicalPath::join(search_path, path).string();
-            if (Core::DeprecatedFile::exists(full_path)) {
+            if (FileSystem::exists(full_path)) {
                 found = true;
                 break;
             }

Userland/Libraries/LibTest/JavaScriptTestRunnerMain.cpp

@@ -8,6 +8,7 @@
 
 #include <LibCore/ArgsParser.h>
 #include <LibCore/DeprecatedFile.h>
+#include <LibFileSystem/FileSystem.h>
 #include <LibTest/JavaScriptTestRunner.h>
 #include <signal.h>
 #include <stdio.h>
@@ -158,7 +159,7 @@ int main(int argc, char** argv)
         common_path = DeprecatedString::formatted("{}/Userland/Libraries/LibJS/Tests/test-common.js", serenity_source_dir);
 #endif
     }
-    if (!Core::DeprecatedFile::is_directory(test_root)) {
+    if (!FileSystem::is_directory(test_root)) {
         warnln("Test root is not a directory: {}", test_root);
         return 1;
     }