RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-15 10:14:58 +00:00
Code Issues Activity Actions

Kernel: Fix a panic in VFS::rename()

Browse source 
If we get an -ENOENT when resolving the target because of some part, that is not
the very last part, missing, we should just return the error instead of panicking
later :^)

To test:
    $ mkdir /tmp/foo/
    $ mv /tmp/foo/ /tmp/bar/

Related to https://github.com/SerenityOS/serenity/issues/1253
This commit is contained in:
Sergey Bugaev 2020-02-20 17:33:14 +03:00 • committed by Andreas Kling
parent 3439498744
commit 1d2986ea15
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/FileSystem/VirtualFileSystem.cpp
View file

@ -433,7 +433,7 @@ KResult VFS::rename(StringView old_path, StringView new_path, Custody& base)
RefPtr<Custody> new_parent_custody;
auto new_custody_or_error = resolve_path(new_path, base, &new_parent_custody);
if (new_custody_or_error.is_error()) {
if (new_custody_or_error.error() != -ENOENT)
if (new_custody_or_error.error() != -ENOENT || !new_parent_custody)
return new_custody_or_error.error();
}