RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 22:27:35 +00:00
Code Issues Activity Actions

BXVGA: Disallow resolutions higher than 4096x2160

Browse source 
There's no sense in allowing arbitrarily huge resolutions. Instead, we
now cap the screen size at 4K DCI resolution and will reject attempts
to go bigger with EINVAL.
This commit is contained in:
Andreas Kling 2020-01-28 20:57:40 +01:00
parent c17f80e720
commit 1d2c9dbc3a
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Kernel/Devices/BXVGADevice.cpp
View file

@ -33,6 +33,9 @@
#include <LibC/errno_numbers.h>
#include <LibC/sys/ioctl_numbers.h>
#define MAX_RESOLUTION_WIDTH 4096
#define MAX_RESOLUTION_HEIGHT 2160
#define VBE_DISPI_IOPORT_INDEX 0x01CE
#define VBE_DISPI_IOPORT_DATA 0x01CF
@ -167,6 +170,8 @@ int BXVGADevice::ioctl(FileDescription&, unsigned request, unsigned arg)
auto* resolution = (FBResolution*)arg;
if (!current->process().validate_read_typed(resolution) || !current->process().validate_write_typed(resolution))
return -EFAULT;
if (resolution->width > MAX_RESOLUTION_WIDTH || resolution->height > MAX_RESOLUTION_HEIGHT)
return -EINVAL;
set_resolution(resolution->width, resolution->height);
resolution->pitch = m_framebuffer_pitch;
resolution->width = m_framebuffer_width;