RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:27:35 +00:00
Code Issues Activity Actions

LibWeb: FlexBox: Use correct source when querying for the main size

Browse source 
This was an error in understanding what calculated_values are and that
those are not what is wanted when getting the main available size of the
box in the FlexFormattingContext.
The calculation around the size calculation is still a bit wonky, but
this is definietly better.
This commit is contained in:
Tobias Christiansen 2021-09-13 21:10:32 +02:00 • committed by Andreas Kling
parent 4c1da4d43a
commit 1d47ec380f
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibWeb/Layout/FlexFormattingContext.cpp
View file

@ -85,15 +85,15 @@ void FlexFormattingContext::run(Box& box, LayoutMode)
auto has_definite_cross_size = [&is_row](Box& box) {
return is_row ? box.has_definite_height() : box.has_definite_width();
};
auto specified_main_size = [&is_row, &get_pixel_size](Box& box) {
auto specified_main_size = [&is_row](Box& box) {
return is_row
? get_pixel_size(box, box.computed_values().width())
: get_pixel_size(box, box.computed_values().height());
? box.width()
: box.height();
};
auto specified_cross_size = [&is_row, &get_pixel_size](Box& box) {
auto specified_cross_size = [&is_row](Box& box) {
return is_row
? get_pixel_size(box, box.computed_values().height())
: get_pixel_size(box, box.computed_values().width());
? box.height()
: box.width();
};
auto has_main_min_size = [&is_row](Box& box) {
return is_row