RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:28:10 +00:00
Code Issues Activity Actions

LibWeb: Coalesce layouts that happen in response to style changes

Browse source 
Instead of doing a forced layout synchronously whenever an element's
style is changed, use a zero-timer to do the forced relayout on next
event loop iteration.

This effectively coalesces a lot of layouts and makes many pages such
as GitHub spend way less time doing redundant layout work.
This commit is contained in:
Andreas Kling 2021-01-09 15:07:37 +01:00
parent d56f4f635a
commit 1d75e82101
3 changed files with 14 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Libraries/LibWeb/DOM/Document.cpp
View file

@ -78,6 +78,10 @@ Document::Document(const URL& url)
m_style_update_timer = Core::Timer::create_single_shot(0, [this] {
update_style();
});
m_forced_layout_timer = Core::Timer::create_single_shot(0, [this] {
force_layout();
});
}
Document::~Document()
@ -156,6 +160,13 @@ void Document::schedule_style_update()
m_style_update_timer->start();
}
void Document::schedule_forced_layout()
{
if (m_forced_layout_timer->is_active())
return;
m_forced_layout_timer->start();
}
bool Document::is_child_allowed(const Node& node) const
{
switch (node.type()) {