RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 06:47:35 +00:00
Code Issues Activity Actions

LibJS: Make Array.of(...items) generic

Browse source 
As well as bring it generally closer to the specification.
This commit is contained in:
Idan Horowitz 2021-06-29 15:06:43 +03:00 • committed by Linus Groh
parent 7ff363127b
commit 1d94d7a367
1 changed files with 20 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

23
Userland/Libraries/LibJS/Runtime/ArrayConstructor.cpp
View file

@ -155,9 +155,26 @@ JS_DEFINE_NATIVE_FUNCTION(ArrayConstructor::is_array)
// 23.1.2.3 Array.of ( ...items ), https://tc39.es/ecma262/#sec-array.of // 23.1.2.3 Array.of ( ...items ), https://tc39.es/ecma262/#sec-array.of
JS_DEFINE_NATIVE_FUNCTION(ArrayConstructor::of) JS_DEFINE_NATIVE_FUNCTION(ArrayConstructor::of)
{ {
auto* array = Array::create(global_object); auto this_value = vm.this_value(global_object);
for (size_t i = 0; i < vm.argument_count(); ++i) Value array;
array->indexed_properties().append(vm.argument(i)); if (this_value.is_constructor()) {
MarkedValueList arguments(vm.heap());
arguments.empend(vm.argument_count());
array = vm.construct(this_value.as_function(), this_value.as_function(), move(arguments));
if (vm.exception())
return {};
} else {
array = Array::create(global_object);
}
auto& array_object = array.as_object();
for (size_t k = 0; k < vm.argument_count(); ++k) {
array_object.define_property(k, vm.argument(k));
if (vm.exception())
return {};
}
array_object.put(vm.names.length, Value(vm.argument_count()));
if (vm.exception())
return {};
return array; return array;
} }