RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 08:48:11 +00:00
Code Issues Activity Actions

LibJS: Have AsyncFunctionDriverWrapper unwrap promises before returning

Browse source 
24 new passes on test262. :^)
This commit is contained in:
Andreas Kling 2023-06-27 10:25:58 +02:00
parent cc9ec6693b
commit 1dc7f03137
1 changed files with 17 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Userland/Libraries/LibJS/Runtime/AsyncFunctionDriverWrapper.cpp
View file

@ -72,12 +72,26 @@ void AsyncFunctionDriverWrapper::continue_async_execution(VM& vm, Value value, b
auto promise_value = TRY(result.get(vm, vm.names.value));
if (TRY(result.get(vm, vm.names.done)).to_boolean()) {
// We hit a `return value;`
m_top_level_promise->fulfill(promise_value);
// We should not execute anymore, so we are safe to allow our selfs to be GC'd
// We should not execute anymore, so we are safe to allow ourselves to be GC'd.
m_self_handle = {};
// When returning a promise, we need to unwrap it.
if (promise_value.is_object() && is<Promise>(promise_value.as_object())) {
auto& returned_promise = static_cast<Promise&>(promise_value.as_object());
if (returned_promise.state() == Promise::State::Fulfilled) {
m_top_level_promise->fulfill(returned_promise.result());
return {};
}
if (returned_promise.state() == Promise::State::Rejected)
return throw_completion(returned_promise.result());
// The promise is still pending but there's nothing more to do here.
return {};
}
// We hit a `return value;`
m_top_level_promise->fulfill(promise_value);
return {};
}