RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:48:11 +00:00
Code Issues Activity Actions

Kernel/Console: Fix gaps between background glyph color

Browse source
This commit is contained in:
MacDue 2022-06-10 12:29:42 +01:00 • committed by Linus Groh
parent 5caf307ec0
commit 1dcdcc7efb
1 changed files with 4 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Kernel/Graphics/Console/GenericFramebufferConsole.cpp
View file

@ -263,12 +263,7 @@ void GenericFramebufferConsoleImpl::clear(size_t x, size_t y, size_t length)
if (y >= max_row()) if (y >= max_row())
y = 0; y = 0;
} }
auto offset_in_framebuffer = framebuffer_offset(x, y); clear_glyph(x, y);
for (size_t glyph_row = 0; glyph_row < m_glyph_rows; glyph_row++) {
memset(offset_in_framebuffer.pixels, 0, m_glyph_columns * sizeof(u32));
offset_in_framebuffer.bytes += framebuffer_pitch();
}
flush_glyph(x, y);
} }
} }
@ -276,7 +271,7 @@ void GenericFramebufferConsoleImpl::clear_glyph(size_t x, size_t y)
{ {
auto offset_in_framebuffer = framebuffer_offset(x, y); auto offset_in_framebuffer = framebuffer_offset(x, y);
for (size_t glyph_row = 0; glyph_row < m_glyph_rows; glyph_row++) { for (size_t glyph_row = 0; glyph_row < m_glyph_rows; glyph_row++) {
memset(offset_in_framebuffer.pixels, 0, m_glyph_columns * sizeof(u32)); memset(offset_in_framebuffer.pixels, 0, (m_glyph_columns + m_glyph_spacing) * sizeof(u32));
offset_in_framebuffer.bytes += framebuffer_pitch(); offset_in_framebuffer.bytes += framebuffer_pitch();
} }
flush_glyph(x, y); flush_glyph(x, y);
@ -322,6 +317,8 @@ void GenericFramebufferConsoleImpl::write(size_t x, size_t y, char ch, Color bac
bool pixel_set = bitmap[glyph_row] & (1 << glyph_column); bool pixel_set = bitmap[glyph_row] & (1 << glyph_column);
offset_in_framebuffer.pixels[m_glyph_columns - glyph_column] = pixel_set ? foreground_color : background_color; offset_in_framebuffer.pixels[m_glyph_columns - glyph_column] = pixel_set ? foreground_color : background_color;
} }
for (size_t spacing_column = 0; spacing_column < m_glyph_spacing; spacing_column++)
offset_in_framebuffer.pixels[m_glyph_columns + spacing_column] = background_color;
offset_in_framebuffer.bytes += framebuffer_pitch(); offset_in_framebuffer.bytes += framebuffer_pitch();
} }
flush_glyph(x, y); flush_glyph(x, y);