diff --git a/Userland/Applications/DisplaySettings/BackgroundSettingsWidget.h b/Userland/Applications/DisplaySettings/BackgroundSettingsWidget.h index fd18bc8424..1f92eda2a0 100644 --- a/Userland/Applications/DisplaySettings/BackgroundSettingsWidget.h +++ b/Userland/Applications/DisplaySettings/BackgroundSettingsWidget.h @@ -13,16 +13,17 @@ #include #include #include +#include namespace DisplaySettings { -class BackgroundSettingsWidget : public GUI::Widget { +class BackgroundSettingsWidget : public GUI::SettingsWindow::Tab { C_OBJECT(BackgroundSettingsWidget); public: virtual ~BackgroundSettingsWidget() override; - void apply_settings(); + virtual void apply_settings() override; private: BackgroundSettingsWidget(); diff --git a/Userland/Applications/DisplaySettings/DesktopSettingsWidget.h b/Userland/Applications/DisplaySettings/DesktopSettingsWidget.h index 1c3c965f76..189d0bf18c 100644 --- a/Userland/Applications/DisplaySettings/DesktopSettingsWidget.h +++ b/Userland/Applications/DisplaySettings/DesktopSettingsWidget.h @@ -7,17 +7,18 @@ #pragma once #include +#include #include namespace DisplaySettings { -class DesktopSettingsWidget : public GUI::Widget { +class DesktopSettingsWidget : public GUI::SettingsWindow::Tab { C_OBJECT(DesktopSettingsWidget); public: virtual ~DesktopSettingsWidget() override; - void apply_settings(); + virtual void apply_settings() override; private: DesktopSettingsWidget(); diff --git a/Userland/Applications/DisplaySettings/FontSettingsWidget.h b/Userland/Applications/DisplaySettings/FontSettingsWidget.h index 4bd734111e..642c7d1934 100644 --- a/Userland/Applications/DisplaySettings/FontSettingsWidget.h +++ b/Userland/Applications/DisplaySettings/FontSettingsWidget.h @@ -7,17 +7,17 @@ #pragma once #include -#include +#include namespace DisplaySettings { -class FontSettingsWidget : public GUI::Widget { +class FontSettingsWidget final : public GUI::SettingsWindow::Tab { C_OBJECT(FontSettingsWidget); public: virtual ~FontSettingsWidget() override; - void apply_settings(); + virtual void apply_settings() override; private: FontSettingsWidget(); diff --git a/Userland/Applications/DisplaySettings/MonitorSettingsWidget.h b/Userland/Applications/DisplaySettings/MonitorSettingsWidget.h index 4b5e609318..a74401e01b 100644 --- a/Userland/Applications/DisplaySettings/MonitorSettingsWidget.h +++ b/Userland/Applications/DisplaySettings/MonitorSettingsWidget.h @@ -11,11 +11,12 @@ #include #include #include +#include #include namespace DisplaySettings { -class MonitorSettingsWidget : public GUI::Widget { +class MonitorSettingsWidget final : public GUI::SettingsWindow::Tab { C_OBJECT(MonitorSettingsWidget); public: @@ -25,7 +26,7 @@ public: show_screen_numbers(false); } - void apply_settings(); + virtual void apply_settings() override; void show_screen_numbers(bool); protected: diff --git a/Userland/Applications/DisplaySettings/main.cpp b/Userland/Applications/DisplaySettings/main.cpp index 5f88de9c96..d42a07cdbf 100644 --- a/Userland/Applications/DisplaySettings/main.cpp +++ b/Userland/Applications/DisplaySettings/main.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2019-2020, Jesse Buhagiar * Copyright (c) 2021, Andreas Kling + * Copyright (c) 2021, Sam Atkins * * SPDX-License-Identifier: BSD-2-Clause */ @@ -11,13 +12,8 @@ #include "MonitorSettingsWidget.h" #include #include -#include -#include #include -#include -#include -#include -#include +#include #include #include @@ -33,54 +29,11 @@ int main(int argc, char** argv) auto app_icon = GUI::Icon::default_icon("app-display-settings"); - auto window = GUI::Window::construct(); - window->set_title("Display Settings"); - window->resize(400, 480); - window->set_resizable(false); - window->set_minimizable(false); - - auto& main_widget = window->set_main_widget(); - main_widget.set_fill_with_background_color(true); - main_widget.set_layout(); - main_widget.layout()->set_margins(4); - main_widget.layout()->set_spacing(6); - - auto& tab_widget = main_widget.add(); - auto& background_settings_widget = tab_widget.add_tab("Background"); - auto& font_settings_widget = tab_widget.add_tab("Fonts"); - auto& monitor_settings_widget = tab_widget.add_tab("Monitor"); - auto& desktop_settings_widget = tab_widget.add_tab("Workspaces"); - - auto& button_container = main_widget.add(); - button_container.set_shrink_to_fit(true); - button_container.set_layout(); - button_container.layout()->set_spacing(6); - button_container.layout()->add_spacer(); - - auto& ok_button = button_container.add("OK"); - ok_button.set_fixed_width(75); - ok_button.on_click = [&](auto) { - background_settings_widget.apply_settings(); - monitor_settings_widget.apply_settings(); - desktop_settings_widget.apply_settings(); - font_settings_widget.apply_settings(); - app->quit(); - }; - - auto& cancel_button = button_container.add("Cancel"); - cancel_button.set_fixed_width(75); - cancel_button.on_click = [&](auto) { - app->quit(); - }; - - auto& apply_button = button_container.add("Apply"); - apply_button.set_fixed_width(75); - apply_button.on_click = [&](auto) { - background_settings_widget.apply_settings(); - monitor_settings_widget.apply_settings(); - desktop_settings_widget.apply_settings(); - font_settings_widget.apply_settings(); - }; + auto window = GUI::SettingsWindow::construct("Display Settings"); + window->add_tab("Background"); + window->add_tab("Fonts"); + window->add_tab("Monitor"); + window->add_tab("Workspaces"); window->set_icon(app_icon.bitmap_for_size(16));