RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 10:47:44 +00:00
Code Issues Activity Actions

LibWeb: Remove FFC::cross_size_is_absolute_or_resolved_nicely()

Browse source 
This is now answered authoritatively by Layout::Box itself.
This commit is contained in:
Andreas Kling 2022-02-27 17:15:37 +01:00
parent 1ce1af5d8b
commit 1dfb3d555c
2 changed files with 1 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

25
Userland/Libraries/LibWeb/Layout/FlexFormattingContext.cpp
View file

@ -245,30 +245,7 @@ bool FlexFormattingContext::has_cross_min_size(Box const& box) const
bool FlexFormattingContext::has_definite_cross_size(Box const& box) const bool FlexFormattingContext::has_definite_cross_size(Box const& box) const
{ {
return (is_row_layout() ? box.has_definite_height() : box.has_definite_width()) && cross_size_is_absolute_or_resolved_nicely(box); return is_row_layout() ? box.has_definite_height() : box.has_definite_width();
}
bool FlexFormattingContext::cross_size_is_absolute_or_resolved_nicely(NodeWithStyle const& box) const
{
auto length_percentage = is_row_layout() ? box.computed_values().height() : box.computed_values().width();
if (!length_percentage.has_value())
return false;
// FIXME: Handle calc here.
if (length_percentage->is_length()) {
auto& length = length_percentage->length();
if (length.is_absolute() || length.is_relative())
return true;
if (length.is_auto())
return false;
}
if (!box.parent())
return false;
if (length_percentage->is_percentage() && cross_size_is_absolute_or_resolved_nicely(*box.parent()))
return true;
return false;
} }
float FlexFormattingContext::specified_main_size_of_child_box(Box const& child_box) const float FlexFormattingContext::specified_main_size_of_child_box(Box const& child_box) const

1
Userland/Libraries/LibWeb/Layout/FlexFormattingContext.h
View file

@ -61,7 +61,6 @@ private:
float specified_cross_size(Box const&) const; float specified_cross_size(Box const&) const;
bool has_main_min_size(Box const&) const; bool has_main_min_size(Box const&) const;
bool has_cross_min_size(Box const&) const; bool has_cross_min_size(Box const&) const;
bool cross_size_is_absolute_or_resolved_nicely(NodeWithStyle const&) const;
float specified_main_max_size(Box const&) const; float specified_main_max_size(Box const&) const;
float specified_cross_max_size(Box const&) const; float specified_cross_max_size(Box const&) const;
float calculated_main_size(Box const&) const; float calculated_main_size(Box const&) const;