RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 14:07:45 +00:00
Code Issues Activity Actions

LibCore: Avoid a big malloc in CIODevice's internal buffering.

Browse source 
This heap allocation was totally avoidable and can be replaced by a stack
buffer instead. Dodges a bunch of mmap() traffic.
This commit is contained in:
Andreas Kling 2019-05-14 16:36:29 +02:00
parent 7c10a93d48
commit 1e0f9d325c
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
LibCore/CIODevice.cpp
View file

@ -146,8 +146,8 @@ bool CIODevice::populate_read_buffer()
{ {
if (m_fd < 0) if (m_fd < 0)
return false; return false;
auto buffer = ByteBuffer::create_uninitialized(PAGE_SIZE); byte buffer[1024];
int nread = ::read(m_fd, buffer.pointer(), buffer.size()); int nread = ::read(m_fd, buffer, sizeof(buffer));
if (nread < 0) { if (nread < 0) {
set_error(errno); set_error(errno);
return false; return false;
@ -156,8 +156,7 @@ bool CIODevice::populate_read_buffer()
set_eof(true); set_eof(true);
return false; return false;
} }
buffer.trim(nread); m_buffered_data.append(buffer, nread);
m_buffered_data.append(buffer.pointer(), buffer.size());
return true; return true;
} }