RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:27:43 +00:00
Code Issues Activity Actions

LibCore: Completely drop DeprecatedFile

Browse source 
DeprecatedFile doesn't properly handle I/O or OOM errors, and only
provides a rudimentary interface to reasonably handle it. We have long
since learned how to do it "properly" with ErrorOr<> and similar
interfaces. See also d43a7eae54.

Note that this leaves behind an invocation to DeprecatedFile in
Ladybird/AndroidPlatform.cpp. However, that part of the system has
compilation errors since at least January, and will get removed or
rewritten as part of issue #19085. Let's not wait for this Android port
to remove this deprecated API.
This commit is contained in:
Ben Wiederhake 2023-05-18 15:55:09 +02:00 • committed by Jelle Raaijmakers
parent c5a89e7e6b
commit 1e1caed1f7
5 changed files with 0 additions and 278 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibCore/System.cpp
View file

@ -13,7 +13,6 @@
#include <AK/StdLibExtras.h>
#include <AK/String.h>
#include <AK/Vector.h>
#include <LibCore/DeprecatedFile.h>
#include <LibCore/SessionManagement.h>
#include <LibCore/System.h>
#include <limits.h>