RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:27:45 +00:00
Code Issues Activity Actions

Shell: Fix how cd handles the path argument

Browse source 
Previously this didn't work:

  $ cd -- /usr
  Invalid path '--'

This path fixes this issue and removes the unnecessary else
branch because we're already using realpath() later on to resolve
relative paths.
This commit is contained in:
Gunnar Beutner 2021-04-23 10:42:16 +02:00 • committed by Linus Groh
parent 6a957daba4
commit 1e5a7ca0a7
1 changed files with 1 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Shell/Builtin.cpp
View file

@ -198,14 +198,8 @@ int Shell::builtin_cd(int argc, const char** argv)
if (oldpwd == nullptr) if (oldpwd == nullptr)
return 1; return 1;
new_path = oldpwd; new_path = oldpwd;
} else if (arg_path[0] == '/') {
new_path = argv[1];
} else { } else {
StringBuilder builder; new_path = arg_path;
builder.append(cwd);
builder.append('/');
builder.append(arg_path);
new_path = builder.to_string();
} }
} }