mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 22:57:44 +00:00
LibJS: Add [[GlobalThisValue]] internal slot to GlobalEnvironment
Instead of hardcoding the environment's global object as the return value of GlobalEnvironment::global_this_value(), it now stores an Object reference which is passed to the constructor for this purpose. From the spec (https://tc39.es/ecma262/#sec-global-environment-records): [[GlobalThisValue]] | Object | The value returned by this in global scope. Hosts may provide any ECMAScript Object value.
This commit is contained in:
parent
2b8d5696ab
commit
1e79934acf
4 changed files with 13 additions and 18 deletions
|
@ -13,8 +13,10 @@
|
|||
|
||||
namespace JS {
|
||||
|
||||
GlobalEnvironment::GlobalEnvironment(GlobalObject& global_object)
|
||||
// 9.1.2.5 NewGlobalEnvironment ( G, thisValue ), https://tc39.es/ecma262/#sec-newglobalenvironment
|
||||
GlobalEnvironment::GlobalEnvironment(GlobalObject& global_object, Object& this_value)
|
||||
: Environment(nullptr)
|
||||
, m_global_this_value(&this_value)
|
||||
{
|
||||
m_object_record = global_object.heap().allocate<ObjectEnvironment>(global_object, global_object, ObjectEnvironment::IsWithEnvironment::No, nullptr);
|
||||
m_declarative_record = global_object.heap().allocate<DeclarativeEnvironment>(global_object);
|
||||
|
@ -24,6 +26,7 @@ void GlobalEnvironment::visit_edges(Cell::Visitor& visitor)
|
|||
{
|
||||
Base::visit_edges(visitor);
|
||||
visitor.visit(m_object_record);
|
||||
visitor.visit(m_global_this_value);
|
||||
visitor.visit(m_declarative_record);
|
||||
}
|
||||
|
||||
|
@ -50,11 +53,6 @@ Value GlobalEnvironment::get_this_binding(GlobalObject&) const
|
|||
return &global_object();
|
||||
}
|
||||
|
||||
Value GlobalEnvironment::global_this_value() const
|
||||
{
|
||||
return &global_object();
|
||||
}
|
||||
|
||||
// 9.1.1.4.1 HasBinding ( N ), https://tc39.es/ecma262/#sec-global-environment-records-hasbinding-n
|
||||
bool GlobalEnvironment::has_binding(FlyString const& name) const
|
||||
{
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue