RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 05:07:45 +00:00
Code Issues Activity Actions

Ladybird: Add tooltips for buttons in AppKit version

Browse source
This commit is contained in:
Junior Rantila 2023-09-15 15:01:04 +02:00 • committed by Andrew Kaster
parent 1681d6f721
commit 1f07a18f4e
1 changed files with 14 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Ladybird/AppKit/UI/TabController.mm
View file

@ -313,10 +313,14 @@ enum class IsHistoryNavigation {
- (NSButton*)create_button:(NSImageName)image - (NSButton*)create_button:(NSImageName)image
with_action:(nonnull SEL)action with_action:(nonnull SEL)action
with_tooltip:(NSString*)tooltip
{ {
auto* button = [NSButton buttonWithImage:[NSImage imageNamed:image] auto* button = [NSButton buttonWithImage:[NSImage imageNamed:image]
target:self target:self
action:action]; action:action];
if (tooltip) {
[button setToolTip:tooltip];
}
[button setBordered:NO]; [button setBordered:NO];
return button; return button;
@ -326,7 +330,8 @@ enum class IsHistoryNavigation {
{ {
if (!_navigate_back_toolbar_item) { if (!_navigate_back_toolbar_item) {
auto* button = [self create_button:NSImageNameGoBackTemplate auto* button = [self create_button:NSImageNameGoBackTemplate
with_action:@selector(navigateBack:)]; with_action:@selector(navigateBack:)
with_tooltip:@"Navigate back"];
[button setEnabled:NO]; [button setEnabled:NO];
_navigate_back_toolbar_item = [[NSToolbarItem alloc] initWithItemIdentifier:TOOLBAR_NAVIGATE_BACK_IDENTIFIER]; _navigate_back_toolbar_item = [[NSToolbarItem alloc] initWithItemIdentifier:TOOLBAR_NAVIGATE_BACK_IDENTIFIER];
@ -340,7 +345,8 @@ enum class IsHistoryNavigation {
{ {
if (!_navigate_forward_toolbar_item) { if (!_navigate_forward_toolbar_item) {
auto* button = [self create_button:NSImageNameGoForwardTemplate auto* button = [self create_button:NSImageNameGoForwardTemplate
with_action:@selector(navigateForward:)]; with_action:@selector(navigateForward:)
with_tooltip:@"Navigate forward"];
[button setEnabled:NO]; [button setEnabled:NO];
_navigate_forward_toolbar_item = [[NSToolbarItem alloc] initWithItemIdentifier:TOOLBAR_NAVIGATE_FORWARD_IDENTIFIER]; _navigate_forward_toolbar_item = [[NSToolbarItem alloc] initWithItemIdentifier:TOOLBAR_NAVIGATE_FORWARD_IDENTIFIER];
@ -354,7 +360,8 @@ enum class IsHistoryNavigation {
{ {
if (!_reload_toolbar_item) { if (!_reload_toolbar_item) {
auto* button = [self create_button:NSImageNameRefreshTemplate auto* button = [self create_button:NSImageNameRefreshTemplate
with_action:@selector(reload:)]; with_action:@selector(reload:)
with_tooltip:@"Reload page"];
[button setEnabled:NO]; [button setEnabled:NO];
_reload_toolbar_item = [[NSToolbarItem alloc] initWithItemIdentifier:TOOLBAR_RELOAD_IDENTIFIER]; _reload_toolbar_item = [[NSToolbarItem alloc] initWithItemIdentifier:TOOLBAR_RELOAD_IDENTIFIER];
@ -383,7 +390,8 @@ enum class IsHistoryNavigation {
{ {
if (!_new_tab_toolbar_item) { if (!_new_tab_toolbar_item) {
auto* button = [self create_button:NSImageNameAddTemplate auto* button = [self create_button:NSImageNameAddTemplate
with_action:@selector(createNewTab:)]; with_action:@selector(createNewTab:)
with_tooltip:@"New tab"];
_new_tab_toolbar_item = [[NSToolbarItem alloc] initWithItemIdentifier:TOOLBAR_NEW_TAB_IDENTIFIER]; _new_tab_toolbar_item = [[NSToolbarItem alloc] initWithItemIdentifier:TOOLBAR_NEW_TAB_IDENTIFIER];
[_new_tab_toolbar_item setView:button]; [_new_tab_toolbar_item setView:button];
@ -396,7 +404,8 @@ enum class IsHistoryNavigation {
{ {
if (!_tab_overview_toolbar_item) { if (!_tab_overview_toolbar_item) {
auto* button = [self create_button:NSImageNameIconViewTemplate auto* button = [self create_button:NSImageNameIconViewTemplate
with_action:@selector(showTabOverview:)]; with_action:@selector(showTabOverview:)
with_tooltip:@"Show all tabs"];
_tab_overview_toolbar_item = [[NSToolbarItem alloc] initWithItemIdentifier:TOOLBAR_TAB_OVERVIEW_IDENTIFIER]; _tab_overview_toolbar_item = [[NSToolbarItem alloc] initWithItemIdentifier:TOOLBAR_TAB_OVERVIEW_IDENTIFIER];
[_tab_overview_toolbar_item setView:button]; [_tab_overview_toolbar_item setView:button];