RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 02:17:35 +00:00
Code Issues Activity Actions

LibWeb: Set max-width for inline child boxes after inside layout

Browse source 
max-width for boxes with inline children can only be applied after
inside layout is done and width of box content is known.

Fixes https://github.com/SerenityOS/serenity/issues/20235
This commit is contained in:
Aliaksandr Kalenik 2023-08-02 01:02:44 +03:00 • committed by Andreas Kling
parent 24c848607c
commit 1f28fdacf0
4 changed files with 46 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp
View file

@ -505,8 +505,17 @@ void BlockFormattingContext::layout_inline_children(BlockContainer const& block_
layout_mode,
available_space);
if (!block_container_state.has_definite_width())
block_container_state.set_content_width(context.automatic_content_width());
if (!block_container_state.has_definite_width()) {
// NOTE: max-width for boxes with inline children can only be applied after inside layout is done
// and width of box content is known
auto used_width_px = context.automatic_content_width();
if (!should_treat_max_width_as_none(block_container, available_space.width)) {
auto max_width_px = calculate_inner_width(block_container, available_space.width, block_container.computed_values().max_width()).to_px(block_container);
if (used_width_px > max_width_px)
used_width_px = max_width_px;
}
block_container_state.set_content_width(used_width_px);
}
if (!block_container_state.has_definite_height())
block_container_state.set_content_height(context.automatic_content_height());
}