RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:27:46 +00:00
Code Issues Activity Actions

LibWeb: Use zero automatic minimum size for scroll-container flex items

Browse source 
The "flex item automatic minimum size in the main axis is the
content-based minimum size" behavior should only apply to flex items
that aren't scroll containers. We were doing it for all flex items.
This commit is contained in:
Andreas Kling 2023-03-26 11:57:12 +02:00
parent 8038824211
commit 1f7e6cc022
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/Layout/FlexFormattingContext.cpp
View file

@ -713,8 +713,12 @@ void FlexFormattingContext::determine_flex_base_size_and_hypothetical_main_size(
// https://drafts.csswg.org/css-flexbox-1/#min-size-auto
CSSPixels FlexFormattingContext::automatic_minimum_size(FlexItem const& item) const
{
// FIXME: Deal with scroll containers.
return content_based_minimum_size(item);
// To provide a more reasonable default minimum size for flex items,
// the used value of a main axis automatic minimum size on a flex item that is not a scroll container is its content-based minimum size;
// for scroll containers the automatic minimum size is zero, as usual.
if (!item.box->is_scroll_container())
return content_based_minimum_size(item);
return 0;
}
// https://drafts.csswg.org/css-flexbox-1/#specified-size-suggestion