From 1f82beded3ae3664265f1ddf6075f64ca5a08cde Mon Sep 17 00:00:00 2001 From: Sam Atkins Date: Fri, 13 May 2022 11:45:21 +0100 Subject: [PATCH] LibWeb: Make about:blank load correctly - Don't treat an empty `about:blank` resource as an error. - Give `about:` urls a content-type so `FrameLoader::parse_document()` won't reject them. --- Userland/Libraries/LibWeb/Loader/FrameLoader.cpp | 2 +- Userland/Libraries/LibWeb/Loader/ResourceLoader.cpp | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/Userland/Libraries/LibWeb/Loader/FrameLoader.cpp b/Userland/Libraries/LibWeb/Loader/FrameLoader.cpp index 73d5a17132..94b3aa9b03 100644 --- a/Userland/Libraries/LibWeb/Loader/FrameLoader.cpp +++ b/Userland/Libraries/LibWeb/Loader/FrameLoader.cpp @@ -331,7 +331,7 @@ void FrameLoader::resource_did_load() } m_redirects_count = 0; - if (!resource()->has_encoded_data()) { + if (!resource()->has_encoded_data() && url.to_string() != "about:blank") { load_error_page(url, "No data"); return; } diff --git a/Userland/Libraries/LibWeb/Loader/ResourceLoader.cpp b/Userland/Libraries/LibWeb/Loader/ResourceLoader.cpp index d4d1179b03..e45ae44d27 100644 --- a/Userland/Libraries/LibWeb/Loader/ResourceLoader.cpp +++ b/Userland/Libraries/LibWeb/Loader/ResourceLoader.cpp @@ -150,8 +150,12 @@ void ResourceLoader::load(LoadRequest& request, Function response_headers; + response_headers.set("Content-Type", "text/html; charset=UTF-8"); + + deferred_invoke([success_callback = move(success_callback), response_headers = move(response_headers)] { + success_callback(String::empty().to_byte_buffer(), response_headers, {}); }); return; }