RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 15:17:45 +00:00
Code Issues Activity Actions

LibCrypto+LibJS: Better bigint bitwise_and binop

Browse source 
Bitwise and is defined in terms of two's complement, so some converting
needs to happen for SignedBigInteger's sign/magnitude representation to
work out.

UnsignedBigInteger::bitwise_not() is repurposed to convert all
high-order zero bits to ones up to a limit, for the two's complement
conversion to work.

Fixes test262/test/language/expressions/bitwise-and/bigint.js.
This commit is contained in:
Nico Weber 2022-01-17 19:54:02 -05:00 • committed by Ali Mohammad Pur
parent 945d962322
commit 1f98639396
7 changed files with 52 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Tests/LibCrypto/TestBigInteger.cpp
View file

@ -478,9 +478,11 @@ TEST_CASE(test_signed_bigint_bitwise_and)
auto num1 = "-1234567"_sbigint;
auto num2 = "1234567"_sbigint;
EXPECT_EQ(num1.bitwise_and(num1), num1);
EXPECT_EQ(num1.bitwise_and(num2), num2);
EXPECT_EQ(num2.bitwise_and(num1), num2);
EXPECT_EQ(num1.bitwise_and(num2), "1"_sbigint);
EXPECT_EQ(num2.bitwise_and(num1), "1"_sbigint);
EXPECT_EQ(num2.bitwise_and(num2), num2);
EXPECT_EQ("-3"_sbigint.bitwise_and("-2"_sbigint), "-4"_sbigint);
}
TEST_CASE(test_bigint_bitwise_xor)