RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:17:45 +00:00
Code Issues Activity Actions

LibWeb: Add temporary hack for line-height: calc(...)

Browse source 
At the moment, we can't resolve CSS calc() values without having a
LayoutNode. The new StyleProperties::line_height() overload was trying
to do exactly that, which led to an assertion.

This patch makes `line-height: calc(...)` behave the same as
`line-height: normal` for now and adds a FIXME.
This commit is contained in:
Andreas Kling 2023-03-18 21:15:51 +01:00
parent ed1a7aee43
commit 1f99f9523d
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/CSS/StyleProperties.cpp
View file

@ -161,8 +161,10 @@ CSSPixels StyleProperties::line_height(CSSPixelRect const& viewport_rect, Gfx::F
return Length(percentage.as_fraction(), Length::Type::Em).to_px(viewport_rect, font_metrics, font_size, root_font_size, parent_line_height, root_line_height);
}
if (line_height->is_calculated())
return CSS::Length::make_calculated(const_cast<CalculatedStyleValue&>(line_height->as_calculated())).to_px(viewport_rect, font_metrics, font_size, root_font_size, parent_line_height, root_line_height);
if (line_height->is_calculated()) {
// FIXME: Handle `line-height: calc(...)` despite not having a LayoutNode here.
return font_metrics.line_spacing();
}
return font_metrics.line_spacing();
}