From 1fda417f4fc3201e8617fe28981d0e49f5ed04cc Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Wed, 18 Dec 2019 12:44:13 +0100 Subject: [PATCH] LibHTML: Ignore case of presentation attribute names --- Libraries/LibHTML/DOM/HTMLBodyElement.cpp | 12 ++++++------ Libraries/LibHTML/DOM/HTMLFontElement.cpp | 2 +- Libraries/LibHTML/DOM/HTMLImageElement.cpp | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/Libraries/LibHTML/DOM/HTMLBodyElement.cpp b/Libraries/LibHTML/DOM/HTMLBodyElement.cpp index 03c25c7757..a77f33d1f8 100644 --- a/Libraries/LibHTML/DOM/HTMLBodyElement.cpp +++ b/Libraries/LibHTML/DOM/HTMLBodyElement.cpp @@ -15,15 +15,15 @@ HTMLBodyElement::~HTMLBodyElement() void HTMLBodyElement::apply_presentational_hints(StyleProperties& style) const { for_each_attribute([&](auto& name, auto& value) { - if (name == "bgcolor") { + if (name.equals_ignoring_case("bgcolor")) { auto color = Color::from_string(value); if (color.has_value()) style.set_property(CSS::PropertyID::BackgroundColor, ColorStyleValue::create(color.value())); - } else if (name == "text") { + } else if (name.equals_ignoring_case("text")) { auto color = Color::from_string(value); if (color.has_value()) style.set_property(CSS::PropertyID::Color, ColorStyleValue::create(color.value())); - } else if (name == "background") { + } else if (name.equals_ignoring_case("background")) { style.set_property(CSS::PropertyID::BackgroundImage, ImageStyleValue::create(document().complete_url(value), const_cast(document()))); } }); @@ -31,15 +31,15 @@ void HTMLBodyElement::apply_presentational_hints(StyleProperties& style) const void HTMLBodyElement::parse_attribute(const String& name, const String& value) { - if (name == "link") { + if (name.equals_ignoring_case("link")) { auto color = Color::from_string(value); if (color.has_value()) document().set_link_color(color.value()); - } else if (name == "alink") { + } else if (name.equals_ignoring_case("alink")) { auto color = Color::from_string(value); if (color.has_value()) document().set_active_link_color(color.value()); - } else if (name == "vlink") { + } else if (name.equals_ignoring_case("vlink")) { auto color = Color::from_string(value); if (color.has_value()) document().set_visited_link_color(color.value()); diff --git a/Libraries/LibHTML/DOM/HTMLFontElement.cpp b/Libraries/LibHTML/DOM/HTMLFontElement.cpp index fca7ad0f04..f6157a994c 100644 --- a/Libraries/LibHTML/DOM/HTMLFontElement.cpp +++ b/Libraries/LibHTML/DOM/HTMLFontElement.cpp @@ -14,7 +14,7 @@ HTMLFontElement::~HTMLFontElement() void HTMLFontElement::apply_presentational_hints(StyleProperties& style) const { for_each_attribute([&](auto& name, auto& value) { - if (name == "color") { + if (name.equals_ignoring_case("color")) { auto color = Color::from_string(value); if (color.has_value()) style.set_property(CSS::PropertyID::Color, ColorStyleValue::create(color.value())); diff --git a/Libraries/LibHTML/DOM/HTMLImageElement.cpp b/Libraries/LibHTML/DOM/HTMLImageElement.cpp index 42a0ea70fe..da4afde084 100644 --- a/Libraries/LibHTML/DOM/HTMLImageElement.cpp +++ b/Libraries/LibHTML/DOM/HTMLImageElement.cpp @@ -16,7 +16,7 @@ HTMLImageElement::~HTMLImageElement() void HTMLImageElement::parse_attribute(const String& name, const String& value) { - if (name == "src") + if (name.equals_ignoring_case("src")) load_image(value); }