RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-30 17:08:13 +00:00
Code Issues Activity Actions

LibWeb: Use doubles for CSS dimension types

Browse source 
Avoid unintentionally converting between float and double multiple times
by just using double everywhere. Also, remove the unused `int` versions
of their constructors.
This commit is contained in:
Sam Atkins 2023-08-20 13:02:41 +01:00 • committed by Sam Atkins
parent 95f80bc65b
commit 1feacd4b52
16 changed files with 34 additions and 73 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/CSS/Parser/GradientParsing.cpp
View file

@ -200,7 +200,7 @@ RefPtr<StyleValue> Parser::parse_linear_gradient_function(ComponentValue const&
if (first_param.is(Token::Type::Dimension)) {
// <angle>
tokens.next_token();
float angle_value = first_param.token().dimension_value();
auto angle_value = first_param.token().dimension_value();
auto unit_string = first_param.token().dimension_unit();
auto angle_type = Angle::unit_from_name(unit_string);
@ -320,7 +320,7 @@ RefPtr<StyleValue> Parser::parse_conic_gradient_function(ComponentValue const& c
auto angle_token = tokens.next_token();
if (!angle_token.is(Token::Type::Dimension))
return nullptr;
float angle = angle_token.token().dimension_value();
auto angle = angle_token.token().dimension_value();
auto angle_unit = angle_token.token().dimension_unit();
auto angle_type = Angle::unit_from_name(angle_unit);
if (!angle_type.has_value())