mirror of
https://github.com/RGBCube/serenity
synced 2025-05-31 11:18:11 +00:00
AK: Replace String::trim_spaces() with String::trim_whitespace()
As suggested by @awesomekling in a code review and (initially) ignored by me :^) Implementation is roughly based on LibJS's trim_string(), but with a fix for trimming all-whitespace strings.
This commit is contained in:
parent
0c14ee035c
commit
1febee768d
3 changed files with 41 additions and 12 deletions
|
@ -369,18 +369,42 @@ int String::replace(const String& needle, const String& replacement, bool all_oc
|
|||
return positions.size();
|
||||
}
|
||||
|
||||
String String::trim_spaces() const
|
||||
String String::trim_whitespace(TrimMode mode) const
|
||||
{
|
||||
size_t start = 0;
|
||||
size_t end = length();
|
||||
while (characters()[start] == ' ')
|
||||
++start;
|
||||
while (characters()[end] == ' ') {
|
||||
if (end <= start)
|
||||
return "";
|
||||
--end;
|
||||
auto is_whitespace_character = [](char ch) -> bool {
|
||||
return ch == '\t'
|
||||
|| ch == '\n'
|
||||
|| ch == '\v'
|
||||
|| ch == '\f'
|
||||
|| ch == '\r'
|
||||
|| ch == ' ';
|
||||
};
|
||||
|
||||
size_t substring_start = 0;
|
||||
size_t substring_length = length();
|
||||
|
||||
if (mode == TrimMode::Left || mode == TrimMode::Both) {
|
||||
for (size_t i = 0; i < length(); ++i) {
|
||||
if (substring_length == 0)
|
||||
return "";
|
||||
if (!is_whitespace_character(characters()[i]))
|
||||
break;
|
||||
++substring_start;
|
||||
--substring_length;
|
||||
}
|
||||
}
|
||||
return substring(start, end - start);
|
||||
|
||||
if (mode == TrimMode::Right || mode == TrimMode::Both) {
|
||||
for (size_t i = length() - 1; i > 0; --i) {
|
||||
if (substring_length == 0)
|
||||
return "";
|
||||
if (!is_whitespace_character(characters()[i]))
|
||||
break;
|
||||
--substring_length;
|
||||
}
|
||||
}
|
||||
|
||||
return substring(substring_start, substring_length);
|
||||
}
|
||||
|
||||
String escape_html_entities(const StringView& html)
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue