RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:47:34 +00:00
Code Issues Activity Actions

LibWeb: Make factory method of DOM::Text fallible

Browse source
This commit is contained in:
Kenneth Myhra 2023-02-15 07:47:47 +01:00 • committed by Linus Groh
parent 2411dadc35
commit 200d22c650
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/DOM/Text.cpp
View file

@ -39,11 +39,11 @@ void Text::visit_edges(Cell::Visitor& visitor)
} }
// https://dom.spec.whatwg.org/#dom-text-text // https://dom.spec.whatwg.org/#dom-text-text
JS::NonnullGCPtr<Text> Text::construct_impl(JS::Realm& realm, DeprecatedString const& data) WebIDL::ExceptionOr<JS::NonnullGCPtr<Text>> Text::construct_impl(JS::Realm& realm, DeprecatedString const& data)
{ {
// The new Text(data) constructor steps are to set this’s data to data and this’s node document to current global object’s associated Document. // The new Text(data) constructor steps are to set this’s data to data and this’s node document to current global object’s associated Document.
auto& window = verify_cast<HTML::Window>(HTML::current_global_object()); auto& window = verify_cast<HTML::Window>(HTML::current_global_object());
return realm.heap().allocate<Text>(realm, window.associated_document(), data).release_allocated_value_but_fixme_should_propagate_errors(); return MUST_OR_THROW_OOM(realm.heap().allocate<Text>(realm, window.associated_document(), data));
} }
void Text::set_owner_input_element(Badge<HTML::HTMLInputElement>, HTML::HTMLInputElement& input_element) void Text::set_owner_input_element(Badge<HTML::HTMLInputElement>, HTML::HTMLInputElement& input_element)

2
Userland/Libraries/LibWeb/DOM/Text.h
View file

@ -18,7 +18,7 @@ class Text : public CharacterData {
public: public:
virtual ~Text() override = default; virtual ~Text() override = default;
static JS::NonnullGCPtr<Text> construct_impl(JS::Realm& realm, DeprecatedString const& data); static WebIDL::ExceptionOr<JS::NonnullGCPtr<Text>> construct_impl(JS::Realm& realm, DeprecatedString const& data);
// ^Node // ^Node
virtual DeprecatedFlyString node_name() const override { return "#text"; } virtual DeprecatedFlyString node_name() const override { return "#text"; }