mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 22:07:35 +00:00
LibWeb: Don't treat erroring subresource loads as success
If a subresource fails to load, we don't care that we got some custom 404 page. The subresource should still be considered failed. This is an ad-hoc solution that unbreaks Acid2. This code will eventually be replaced by fetch mechanisms.
This commit is contained in:
parent
954d660094
commit
20132da88d
3 changed files with 9 additions and 1 deletions
|
@ -24,6 +24,11 @@ public:
|
|||
|
||||
static LoadRequest create_for_url_on_page(const AK::URL& url, Page* page);
|
||||
|
||||
// The main resource is the file being displayed in a frame (unlike subresources like images, scripts, etc.)
|
||||
// If a main resource fails with an HTTP error, we may still display its content if non-empty, e.g a custom 404 page.
|
||||
bool is_main_resource() const { return m_main_resource; }
|
||||
void set_main_resource(bool b) { m_main_resource = b; }
|
||||
|
||||
bool is_valid() const { return m_url.is_valid(); }
|
||||
|
||||
const AK::URL& url() const { return m_url; }
|
||||
|
@ -75,6 +80,7 @@ private:
|
|||
ByteBuffer m_body;
|
||||
Core::ElapsedTimer m_load_timer;
|
||||
Optional<Page&> m_page;
|
||||
bool m_main_resource { false };
|
||||
};
|
||||
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue