From 2028fbeae33118cdff6c554dfb2f098150209ff4 Mon Sep 17 00:00:00 2001 From: thankyouverycool <66646555+thankyouverycool@users.noreply.github.com> Date: Thu, 17 Nov 2022 09:15:12 -0500 Subject: [PATCH] LibGUI: Remove redundant event handling in EmojiInputDialog The Dialog class already handles closing on escape. --- Userland/Libraries/LibGUI/EmojiInputDialog.cpp | 13 ------------- Userland/Libraries/LibGUI/EmojiInputDialog.h | 1 - 2 files changed, 14 deletions(-) diff --git a/Userland/Libraries/LibGUI/EmojiInputDialog.cpp b/Userland/Libraries/LibGUI/EmojiInputDialog.cpp index 36bf933f1e..849177ce4a 100644 --- a/Userland/Libraries/LibGUI/EmojiInputDialog.cpp +++ b/Userland/Libraries/LibGUI/EmojiInputDialog.cpp @@ -19,7 +19,6 @@ #include #include #include -#include #include #include #include @@ -262,16 +261,4 @@ void EmojiInputDialog::select_first_displayed_emoji() done(ExecResult::OK); } -void EmojiInputDialog::event(Core::Event& event) -{ - if (event.type() == Event::KeyDown) { - auto& key_event = static_cast(event); - if (key_event.key() == Key_Escape) { - done(ExecResult::Cancel); - return; - } - } - Dialog::event(event); -} - } diff --git a/Userland/Libraries/LibGUI/EmojiInputDialog.h b/Userland/Libraries/LibGUI/EmojiInputDialog.h index beb139520c..d31b9f98dd 100644 --- a/Userland/Libraries/LibGUI/EmojiInputDialog.h +++ b/Userland/Libraries/LibGUI/EmojiInputDialog.h @@ -26,7 +26,6 @@ public: String const& selected_emoji_text() const { return m_selected_emoji_text; } private: - virtual void event(Core::Event&) override; explicit EmojiInputDialog(Window* parent_window); Vector supported_emoji();