RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 21:47:46 +00:00
Code Issues Activity Actions

LibJS: Change non-ScriptFunction source string to "[native code]"

Browse source 
https://tc39.es/ecma262/#sec-function.prototype.tostring - this is how
the spec wants us to do it. :^)

Also change the function name behaviour to only provide a name for
NativeFunctions, which matches other engines - presumably to not expose
Proxy objects, and to prevent "function bound foo() { [native code] }".
This commit is contained in:
Linus Groh 2021-03-14 19:10:07 +01:00 • committed by Andreas Kling
parent f9287fca1e
commit 202f855055
2 changed files with 13 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Tests/builtins/Function/Function.prototype.toString.js
View file

@ -12,6 +12,6 @@ test("basic functionality", () => {
return bar + 42;
}.toString()
).toBe("function (foo, bar, baz) {\n ???\n}");
expect(console.debug.toString()).toBe("function debug() {\n [NativeFunction]\n}");
expect(Function.toString()).toBe("function Function() {\n [FunctionConstructor]\n}");
expect(console.debug.toString()).toBe("function debug() {\n [native code]\n}");
expect(Function.toString()).toBe("function Function() {\n [native code]\n}");
});