RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 20:07:36 +00:00
Code Issues Activity Actions

Kernel: Make KBufferBuilder::append() & friends return KResult

Browse source 
This allows callers to react to a failed append (due to OOM.)
This commit is contained in:
Andreas Kling 2021-09-06 18:24:13 +02:00
parent b096e85777
commit 2065ced8f6
7 changed files with 63 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Kernel/KBufferBuilder.h
View file

@ -20,26 +20,33 @@ public:
KBufferBuilder(KBufferBuilder&&) = default;
~KBufferBuilder() = default;
void append(const StringView&);
void append(char);
void append(const char*, int);
KResult append(const StringView&);
KResult append(char);
KResult append(const char*, int);
void append_escaped_for_json(const StringView&);
void append_bytes(ReadonlyBytes);
KResult append_escaped_for_json(const StringView&);
KResult append_bytes(ReadonlyBytes);
template<typename... Parameters>
void appendff(CheckedFormatString<Parameters...>&& fmtstr, const Parameters&... parameters)
KResult appendff(CheckedFormatString<Parameters...>&& fmtstr, const Parameters&... parameters)
{
// FIXME: This really not ideal, but vformat expects StringBuilder.
StringBuilder builder;
AK::VariadicFormatParams variadic_format_params { parameters... };
vformat(builder, fmtstr.view(), variadic_format_params);
append_bytes(builder.string_view().bytes());
return append_bytes(builder.string_view().bytes());
}
bool flush();
OwnPtr<KBuffer> build();
ReadonlyBytes bytes() const
{
if (!m_buffer)
return {};
return ReadonlyBytes { m_buffer->data(), m_buffer->size() };
}
private:
bool check_expand(size_t);
u8* insertion_ptr()