RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:47:45 +00:00
Code Issues Activity Actions

LibRegex: Allow null bytes in pattern

Browse source 
That check was rather pointless as the input is a StringView which knows
its own bounds.
Fixes #9686.
This commit is contained in:
Ali Mohammad Pur 2021-08-30 20:20:58 +04:30 • committed by Andreas Kling
parent 0de35db0f1
commit 206bc01f81
2 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibRegex/Regex.cpp
View file

@ -660,6 +660,7 @@ TEST_CASE(ECMA262_match)
{ "[\\0]"sv, "\0"sv, true, ECMAScriptFlags::BrowserExtended }, { "[\\0]"sv, "\0"sv, true, ECMAScriptFlags::BrowserExtended },
{ "[\\0]"sv, "\0"sv, true, combine_flags(ECMAScriptFlags::Unicode, ECMAScriptFlags::BrowserExtended) }, { "[\\0]"sv, "\0"sv, true, combine_flags(ECMAScriptFlags::Unicode, ECMAScriptFlags::BrowserExtended) },
{ "[\\01]"sv, "\1"sv, true, ECMAScriptFlags::BrowserExtended }, { "[\\01]"sv, "\1"sv, true, ECMAScriptFlags::BrowserExtended },
{ "(\0|a)"sv, "a"sv, true }, // #9686, Should allow null bytes in pattern
}; };
// clang-format on // clang-format on

5
Userland/Libraries/LibRegex/RegexLexer.cpp
View file

@ -109,7 +109,7 @@ Token Lexer::next()
} }
}; };
while (m_index <= m_input.length()) { while (m_index < m_input.length()) {
auto ch = peek(); auto ch = peek();
if (ch == '(') if (ch == '(')
return emit_token(TokenType::LeftParen); return emit_token(TokenType::LeftParen);
@ -175,9 +175,6 @@ Token Lexer::next()
} }
} }
if (ch == '\0')
break;
return emit_token(TokenType::Char); return emit_token(TokenType::Char);
} }