RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-02 23:22:07 +00:00
Code Issues Activity Actions

LibWeb: Include table cell border widths when calculating cell rects

Browse source 
Previously, table cells would overlap when they had CSS border or
padding properties defined.
This commit is contained in:
Karol Kosek 2022-03-21 16:35:28 +01:00 • committed by Andreas Kling
parent 68f3feb1d1
commit 20730c164c
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/Layout/TableFormattingContext.cpp
View file

@ -85,7 +85,7 @@ void TableFormattingContext::calculate_column_widths(Box const& row, Vector<floa
} else {
(void)layout_inside(cell, LayoutMode::Normal);
}
column_widths[column_index] = max(column_widths[column_index], cell_state.content_width);
column_widths[column_index] = max(column_widths[column_index], cell_state.border_box_width());
column_index += cell.colspan();
});
}
@ -115,7 +115,7 @@ void TableFormattingContext::layout_row(Box const& row, Vector<float>& column_wi
size_t cell_colspan = cell.colspan();
for (size_t i = 0; i < cell_colspan; ++i)
content_width += column_widths[column_index++];
tallest_cell_height = max(tallest_cell_height, cell_state.content_height);
tallest_cell_height = max(tallest_cell_height, cell_state.border_box_height());
});
if (use_auto_layout) {