From 20c6dabaff5d06300008beb8572e5da8ca61129f Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Sun, 20 Mar 2022 20:19:42 -0400 Subject: [PATCH] Lagom: Build with -fsigned-char When building on an arm host system, char defaults to unsigned, leading to errors such as: serenity/AK/StringBuilder.cpp:198:20: error: comparison is always true due to limited range of data type [-Werror=type-limits] 198 | if (ch >= 0 && ch <= 0x1f) | Building with -fsigned-char makes things work like on Intel, and it's what we already do in Kernel/CMakeLists.txt for the same reasons. --- Meta/Lagom/CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Meta/Lagom/CMakeLists.txt b/Meta/Lagom/CMakeLists.txt index b4c29c8cf9..6d1b0a8a28 100644 --- a/Meta/Lagom/CMakeLists.txt +++ b/Meta/Lagom/CMakeLists.txt @@ -57,6 +57,7 @@ endif() include(wasm_spec_tests) +add_compile_options(-fsigned-char) add_compile_options(-Wno-unknown-warning-option -Wno-literal-suffix -Wno-implicit-const-int-float-conversion) add_compile_options(-O2) add_compile_options(-Wall -Wextra -Werror)